enh 434: instance template should support multiple NICs #31

alexkonkin · 2019-05-16T15:09:02Z

No description provided.

googlebot · 2019-05-16T15:09:09Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

alexkonkin · 2019-05-16T15:22:40Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
* It's possible we don't have your GitHub username or you're using a different email address on your commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).
Corporate signers
* Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to [go/cla#troubleshoot](http://go/cla#troubleshoot) ([Public version](https://opensource.google.com/docs/cla/#troubleshoot)).

* The email used to register you as an authorized contributor must be the email used for the Git commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).

* The email used to register you as an authorized contributor must also be [attached to your GitHub account](https://github.com/settings/emails).
ℹ️ Googlers: Go here for more info.

I signed it!

googlebot · 2019-05-16T15:22:42Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2019-05-19T16:09:36Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

ocsig · 2019-05-19T16:12:55Z

dm/templates/instance/instance.py.schema

@@ -25,53 +25,61 @@ required:
  - zone
  - machineType
  - diskImage
-  - network


Please update your implementation in a way that both 'network' (as the current implementation) as 'networks' (the new implementation) is supported to assure backwards compatibility.

ocsig · 2019-05-19T16:13:40Z

dm/templates/instance_template/instance_template.py.schema

@@ -20,7 +20,7 @@ info:

 required:
  - diskImage
-  - network


Please update your implementation in a way that both 'network' (as the current implementation) as 'networks' (the new implementation) is supported to assure backwards compatibility.

googlebot · 2019-05-20T14:04:32Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-05-20T14:09:35Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-05-20T14:11:58Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

GoogleCloudPlatform/deploymentmanager-samples#434

googlebot · 2019-05-20T14:21:21Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

akopachevskyy-globallogic · 2019-05-20T15:08:26Z

dm/templates/instance/tests/integration/instance_1_nic.yaml

@@ -17,9 +17,20 @@ resources:
      machineType: f1-micro
      diskType: pd-ssd
      canIpForward: true
-      network: test-network-${RAND}
-      subnetwork: regions/us-central1/subnetworks/test-subnet-${RAND}
+      networks:


why we don't use "network" in this case?

Andriy, this test is dedicated to the networks property.
We have a separate test that should also check the network property.

googlebot · 2019-05-20T22:04:28Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

ocsig · 2019-05-21T07:38:06Z

Please update the Managed Instance Group Schema to support the multi NIC Instance templates

GoogleCloudPlatform#31 Fixes DM#434 for managed_instance_group GoogleCloudPlatform/deploymentmanager-samples#434

…ates, MIGs with backwards compatibility * Fixes instance & instance template errors introduces in this PR: #42 Issue: GoogleCloudPlatform/deploymentmanager-samples#434 * Additional fix * Reverted fix * Follow-up for #31 Fixes DM#434 for managed_instance_group GoogleCloudPlatform/deploymentmanager-samples#434

…ates, MIGs with backwards compatibility * Fixes instance & instance template errors introduces in this PR: GoogleCloudPlatform/cloud-foundation-toolkit#42 Issue: GoogleCloudPlatform/deploymentmanager-samples#434 * Additional fix * Reverted fix * Follow-up for GoogleCloudPlatform/cloud-foundation-toolkit#31 Fixes DM#434 for managed_instance_group GoogleCloudPlatform/deploymentmanager-samples#434

alexkonkin force-pushed the feature/434_instance_template_multi_NIC_support branch from 7eb9f04 to 5f1b4e9 Compare May 17, 2019 14:47

ocsig self-assigned this May 19, 2019

ocsig added DM Deployment Manager CFT cla: yes labels May 19, 2019

ocsig reviewed May 19, 2019

View reviewed changes

googlebot added cla: no and removed cla: yes labels May 20, 2019

ocsig added cla: yes and removed cla: no labels May 20, 2019

alexkonkin added 3 commits May 20, 2019 17:11

enh 434: instance template should support multiple NICs

9c67d0e

added tests for 2 network interface cards

494c994

added integration tests for networks property

7333011

alexkonkin force-pushed the feature/434_instance_template_multi_NIC_support branch from d5282d7 to 7333011 Compare May 20, 2019 14:11

Fixes DM 434: CFT - Instance template multi NIC support

dc7a89f

GoogleCloudPlatform/deploymentmanager-samples#434

googlebot added cla: no and removed cla: yes labels May 20, 2019

Fixed single network

918bcfa

akopachevskyy-globallogic reviewed May 20, 2019

View reviewed changes

alexkonkin and others added 3 commits May 20, 2019 18:24

added test for the network property

1e089b2

Instance template update: DM GoogleCloudPlatform#434

ac290c4

added test for network property

6c7eae8

ocsig added cla: yes and removed cla: no labels May 20, 2019

morgante requested a review from ocsig May 21, 2019 01:03

ocsig merged commit fc452a8 into GoogleCloudPlatform:master May 22, 2019

bohdanyurov-gl added a commit to bohdanyurov-gl/cloud-foundation-toolkit that referenced this pull request May 23, 2019

Follow-up for

bb735e6

GoogleCloudPlatform#31 Fixes DM#434 for managed_instance_group GoogleCloudPlatform/deploymentmanager-samples#434

ocsig mentioned this pull request May 24, 2019

Fix/dm 434 #46

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enh 434: instance template should support multiple NICs #31

enh 434: instance template should support multiple NICs #31

alexkonkin commented May 16, 2019

googlebot commented May 16, 2019

alexkonkin commented May 16, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented May 16, 2019

googlebot commented May 19, 2019

ocsig May 19, 2019

ocsig May 19, 2019

googlebot commented May 20, 2019

googlebot commented May 20, 2019

googlebot commented May 20, 2019

googlebot commented May 20, 2019

akopachevskyy-globallogic May 20, 2019

alexkonkin May 20, 2019 •

edited

Loading

googlebot commented May 20, 2019

ocsig commented May 21, 2019

enh 434: instance template should support multiple NICs #31

enh 434: instance template should support multiple NICs #31

Conversation

alexkonkin commented May 16, 2019

googlebot commented May 16, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

alexkonkin commented May 16, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented May 16, 2019

googlebot commented May 19, 2019

ocsig May 19, 2019

Choose a reason for hiding this comment

ocsig May 19, 2019

Choose a reason for hiding this comment

googlebot commented May 20, 2019

googlebot commented May 20, 2019

googlebot commented May 20, 2019

googlebot commented May 20, 2019

akopachevskyy-globallogic May 20, 2019

Choose a reason for hiding this comment

alexkonkin May 20, 2019 • edited Loading

Choose a reason for hiding this comment

googlebot commented May 20, 2019

ocsig commented May 21, 2019

alexkonkin May 20, 2019 •

edited

Loading