Skip to content
This repository has been archived by the owner on Nov 2, 2024. It is now read-only.

Add tests to make sure services are healthy #838

Closed
daniel-sanche opened this issue Oct 4, 2021 · 4 comments
Closed

Add tests to make sure services are healthy #838

daniel-sanche opened this issue Oct 4, 2021 · 4 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone

Comments

@daniel-sanche
Copy link
Member

We want to make sure fresh sandboxes don't have any errors. Either error logs, or failing SLOs

@daniel-sanche daniel-sanche added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Oct 4, 2021
@daniel-sanche daniel-sanche added this to the v0.8.0 milestone Oct 4, 2021
@daniel-sanche
Copy link
Member Author

daniel-sanche commented Oct 7, 2021

Hey @winter-code, since this is your first bug, I'll leave some set-up instructions here:

Background References

Deployment

  • see CONTRIBUTING.md
  • TL;DR:
    • clone the repo's develop branch (we use separate branches for development and stable release code. more info on our process here)
    • create a GKE cluster with make cluster PROJECT_ID=my-project (or other method. Contributing file describes alternatives, but the makefile should be simplest)
    • build/deploy the local code to your cluster using make deploy PROJECT_ID=my-project

Viewing Logs Looking for Errors

  • Look through the logs coming from your cluster in the Cloud Logging UI
  • Look through all the services and see if you see any orange or red error logs. If not, we can skip to writing tests. If you do, ping me and update this bug, and we can try to track down the cause

Writing Tests

@daniel-sanche
Copy link
Member Author

daniel-sanche commented Oct 7, 2021

Also, the previous comment was focused on the GKE code, but we also have a new service running on App Engine. So after the GKE part, you'll have to do the same deployment, viewing logs, and writing tests steps against that one too. But we can do that part at the end

@daniel-sanche
Copy link
Member Author

This is partially addressed in #932, although we may want to check for error logs. (It currently just checks to make sure logs are coming in)

@daniel-sanche daniel-sanche modified the milestones: v1.0.0, v0.7.8 Jun 3, 2022
@arbrown arbrown removed this from the v0.8.1 milestone Aug 15, 2022
@minherz minherz added this to the Backlog milestone Oct 1, 2022
@minherz minherz modified the milestones: backlog, version 0.9 Apr 19, 2023
@minherz
Copy link
Contributor

minherz commented Apr 19, 2023

Correctness of Online Boutique is controlled via the pinned version in kustomization configuration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants