Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MariaDB R2DBC driver #990

Closed
elefeint opened this issue Sep 16, 2022 · 4 comments · Fixed by #1717
Closed

Support MariaDB R2DBC driver #990

elefeint opened this issue Sep 16, 2022 · 4 comments · Fixed by #1717
Assignees
@ttosta-google
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@elefeint
Copy link

Right now, only the MySQL driver is supported in socket factory. Unfortunately, the driver is no longer maintained, and Spring recommendation is to use the MariaDB driver. They should be protocol-compatible.

This will require adding a new ConnectionFactoryProvider similar to the existing GcpConnectionFactoryProviderMysql.
@elefeint elefeint added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 16, 2022
@elefeint
Copy link
Author

@JoeWang1127 Could you take a look at implementing the MariaDB R2DBC support in this repo? @mpeddada1 implemented the original MySQL/CloudSQL autoconfiguration in Spring Cloud GCP that's based on the R2DBC connection factories in this repo.

@shubha-rajan shubha-rajan added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Sep 19, 2022
@JoeWang1127
Copy link

Sure, will do

@JoeWang1127 JoeWang1127 mentioned this issue Sep 20, 2022
Closed
3 tasks
@elefeint elefeint mentioned this issue Sep 27, 2022
Closed
@elefeint
Copy link
Author

This is blocked on adding the SSL tunneling capability into the MariaDB driver.

@elefeint elefeint mentioned this issue Oct 7, 2022
Merged
@shubha-rajan
Copy link
Contributor

Following up on this since the SSL Tunnel mode patch has landed. Do we plan to finish this implementation soon?

@davin111 davin111 mentioned this issue Apr 18, 2023
Open
@ttosta-google ttosta-google self-assigned this Nov 8, 2023
@ttosta-google ttosta-google mentioned this issue Dec 7, 2023
Merged
ttosta-google added a commit that referenced this issue Dec 14, 2023
@ttosta-google
Merge branch 'main' into gh-990-add-support-r2dbc-mariadb
f8a97b2
ttosta-google added a commit that referenced this issue Jan 29, 2024
@ttosta-google
Merge branch 'main' into gh-990-add-support-r2dbc-mariadb
c5c99a9
ttosta-google added a commit that referenced this issue Feb 23, 2024
@ttosta-google
Merge branch 'main' into gh-990-add-support-r2dbc-mariadb
dd03be2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttosta-google ttosta-google

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
4 participants
@shubha-rajan @elefeint @ttosta-google @JoeWang1127