Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

chore(gitignore): expand rules to github/gitignore Python standard #1

Merged
merged 1 commit into from
May 18, 2021

Conversation

grayside
Copy link
Collaborator

@grayside grayside commented May 14, 2021

GitHub uses github/gitignore for default Python gitignore. gitignores in that repository are a great starting place if not using GitHub to initialize an empty repository.

This issue contributes towards #4

@grayside grayside self-assigned this May 14, 2021
@grayside grayside requested review from ace-n and engelke May 14, 2021 19:38
@grayside grayside added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels May 14, 2021
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I assume we'll add things like frontend artifacts in the future, whichj we'll need if we end up using e.g a JS build system.

@grayside
Copy link
Collaborator Author

Ace: Yes, I expect that as well. We'll also have gitignore rules around terraform. We'll have a "monorepo gitignore manageability" decision to make in the future about whether to centralize all our gitignore rules or have each component self-declare.

@grayside grayside changed the title chore(gitignore): expand rules to github/gitignore standard chore(gitignore): expand rules to github/gitignore Python standard May 18, 2021
@grayside grayside merged commit 8fc390c into main May 18, 2021
@grayside grayside deleted the gitignore branch May 18, 2021 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants