feat(terraform): automate firestore setup #163

grayside · 2021-09-03T17:48:29Z

Fixes #114

This change is based on proven work in another project. I did not test as part of Emblem because our current Emblem Terraform setup is not compatible with how I understand how to test Terraform. Sending PR to get reviews started, but flagging as do-not-merge for now while I sort out what needs to happen.

…ignation for app

terraform/prod.tf

terraform/stage.tf

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

google-cla · 2021-09-03T21:35:56Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-03T21:45:19Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

dinagraves · 2021-09-07T23:05:25Z

terraform/prod.tf

+resource "google_app_engine_application" "prod_app" {
+  project = "emblem-prod-${var.suffix}"
+  # us-central1 not recognized by App Engine resource.
+  location_id   = "us-central"


This should be a variable.

Suggested change

location_id = "us-central"

location_id = var.google_region

Once I saw this suggestion in code, I realized this is a problem. Terraform expects app engine regions in a different formation, e.g., us-central. At the same time, Cloud Run expects standard regions us-central1.

From https://cloud.google.com/appengine/docs/locations it looks like we can adapt the Cloud Run region to App Engine by removing the numeric suffix. I'll need to investigate string manipulation options in Terraform.

@dinagraves should the comment above location_id be more emphatic? Even seeing it in the GitHub UI neither of us noticed it providing critical context to this discussion.

terraform/stage.tf

google-cla · 2021-09-07T23:06:17Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-08T00:08:03Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-13T22:23:14Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

dinagraves · 2021-09-13T22:23:55Z

terraform/prod.tf

+resource "google_app_engine_application" "prod_app" {
+  project = "emblem-prod-${var.suffix}"
+  # us-central1 not recognized by App Engine resource.
+  # https://cloud.google.com/appengine/docs/locations


Can you add what this is expected to return?

Overhauled the comment.

terraform/prod.tf

terraform/stage.tf

Co-authored-by: Dina Graves Portman <dinagraves@google.com>

google-cla · 2021-09-15T18:51:58Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-15T19:00:46Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

feat(terraform): automate firestore setup

b5a3135

grayside added the component: delivery Related to automation, testing, deployment of the application. label Sep 3, 2021

grayside requested a review from dinagraves September 3, 2021 17:48

grayside self-assigned this Sep 3, 2021

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 3, 2021

grayside added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 3, 2021

terraform: add provider to service enablement and correct project des…

27677df

…ignation for app

github-actions bot reviewed Sep 3, 2021

View reviewed changes

terraform/prod.tf Outdated Show resolved Hide resolved

terraform/prod.tf Outdated Show resolved Hide resolved

terraform/stage.tf Outdated Show resolved Hide resolved

terraform/stage.tf Outdated Show resolved Hide resolved

terraform-style: Apply suggestions from code review

c6570b2

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 3, 2021

grayside added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 3, 2021

docs: add instructions on running terraform

ea5ad1f

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 3, 2021

grayside added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Sep 3, 2021

grayside added this to the v0.5.0 milestone Sep 7, 2021

dinagraves reviewed Sep 7, 2021

View reviewed changes

Merge branch 'main' into automate-firestore

513603f

dinagraves requested a review from a team as a code owner September 7, 2021 23:06

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 7, 2021

grayside added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 7, 2021

derive firestore location from Cloud Run region

5774e46

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 8, 2021

grayside added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 8, 2021

Merge branch 'main' into automate-firestore

b0bc50c

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 13, 2021

dinagraves approved these changes Sep 13, 2021

View reviewed changes

Update standard project assignment

47168b6

Co-authored-by: Dina Graves Portman <dinagraves@google.com>

Improve comment on app engine location limitations

033319f

grayside added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 15, 2021

grayside merged commit 748db4f into main Sep 15, 2021

pattishin deleted the automate-firestore branch January 6, 2023 16:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(terraform): automate firestore setup #163

feat(terraform): automate firestore setup #163

grayside commented Sep 3, 2021

google-cla bot commented Sep 3, 2021

google-cla bot commented Sep 3, 2021

dinagraves Sep 7, 2021 •

edited

Loading

grayside Sep 7, 2021

google-cla bot commented Sep 7, 2021

google-cla bot commented Sep 8, 2021

google-cla bot commented Sep 13, 2021

dinagraves Sep 13, 2021

grayside Sep 15, 2021

google-cla bot commented Sep 15, 2021

google-cla bot commented Sep 15, 2021

feat(terraform): automate firestore setup #163

feat(terraform): automate firestore setup #163

Conversation

grayside commented Sep 3, 2021

google-cla bot commented Sep 3, 2021

google-cla bot commented Sep 3, 2021

dinagraves Sep 7, 2021 • edited Loading

Choose a reason for hiding this comment

grayside Sep 7, 2021

Choose a reason for hiding this comment

google-cla bot commented Sep 7, 2021

google-cla bot commented Sep 8, 2021

google-cla bot commented Sep 13, 2021

dinagraves Sep 13, 2021

Choose a reason for hiding this comment

grayside Sep 15, 2021

Choose a reason for hiding this comment

google-cla bot commented Sep 15, 2021

google-cla bot commented Sep 15, 2021

dinagraves Sep 7, 2021 •

edited

Loading