Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

fix(website): fix bugs in donation logic #181

Merged
merged 2 commits into from
Sep 15, 2021
Merged

fix(website): fix bugs in donation logic #181

merged 2 commits into from
Sep 15, 2021

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Sep 15, 2021

No description provided.

@ace-n ace-n requested a review from engelke September 15, 2021 21:11
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2021
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Per our external discussion, creation of the API client object is not getting the id token correctly, so this will fail with 403 Forbidden until that's changed.

@ace-n ace-n marked this pull request as ready for review September 15, 2021 23:03
@ace-n ace-n requested a review from a team as a code owner September 15, 2021 23:03
@ace-n
Copy link
Contributor Author

ace-n commented Sep 15, 2021

This doesn't completely fix the problem, but it does get us closer to a solution.

(Per pairing with @engelke, the remaining issues are likely in the client library. Namely, auth tokens are not getting passed to the API.)

@ace-n ace-n merged commit 520fb4a into main Sep 15, 2021
@ace-n ace-n deleted the fix-website branch September 15, 2021 23:04
@grayside grayside added this to the v0.5.0 milestone Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants