fix(terraform): explicitly specify project IDs

[ace-n]

Terraform does not necessarily assume project IDs based on which resources and/or provider are used. This sometimes results in incorrect project IDs being used.

The easiest fix for this is to specify project IDs within resources explicitly, as done in this PR.

Note

terraform apply may still be buggy (even on new projects! - cc @grayside) after this PR is merged. However, this PR should not introduce any new bugs.

[grayside]

My understanding is the reason we assigned provider generally was to help resources inherit project and region from a central location. I prefer setting project and region explicitly, so I like this direction.

However, if we're switching to this, I would expect to see:

• Removing project from providers to avoid potential for conflicts/confusion on project config
• Remove project scoping to providers, in favor of having just google and google-beta working as terraform integration imports

I see this as part of a single change, so I'm flagging this as change requested but perhaps I've misunderstood where you are headed?

[ace-n]

RE resource inheriting - I thought the same, but empirically that inheritance behavior doesn't seem to necessarily be the case.

That said, it also seems like google_project requires a project ID.

Maybe this is a bug in Terraform itself?

[grayside]

I'm not quite sure I followed, are you saying we need a provider per project?

[ace-n]

@grayside we may not. What I'm saying is that we must specify a project ID on any providers we use, because Terraform requires it.

(We may be able to get away with two providers, but I'd rather keep this PR simple and iterate on that question later.)

[grayside]

Thanks for clarifying.