Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

feat(ops): add testing image #385

Merged
merged 5 commits into from
May 31, 2022
Merged

feat(ops): add testing image #385

merged 5 commits into from
May 31, 2022

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented May 18, 2022 •
edited
Loading

This will be necessary to test the Delivery component.

Part of #347

grayside
grayside reviewed May 19, 2022
View reviewed changes
Copy link
Collaborator

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like we are expanding what is already a questionable pattern. Why can't we have one build step that does setup and another build step that drives the tests?

@ace-n

This comment was marked as resolved.

Sign in to view
@ace-n

This comment was marked as resolved.

Sign in to view
@grayside

This comment was marked as resolved.

Sign in to view
@ace-n

This comment was marked as resolved.

Sign in to view
@grayside

This comment was marked as resolved.

Sign in to view
@ace-n ace-n changed the title feat(ops): add Terraform to testing image feat(ops): add ~Terraform to~ testing image May 26, 2022
@ace-n ace-n changed the title feat(ops): add ~Terraform to~ testing image feat(ops): add testing image May 26, 2022
@github-actions github-actions bot added component: delivery Related to automation, testing, deployment of the application. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 26, 2022
@ace-n ace-n marked this pull request as ready for review May 31, 2022 07:08
@ace-n ace-n requested a review from a team as a code owner May 31, 2022 07:08
@ace-n ace-n mentioned this pull request May 31, 2022
Closed
@ace-n ace-n requested a review from grayside May 31, 2022 07:55
@ace-n
Copy link
Contributor Author

ace-n commented May 31, 2022

@grayside this is now in its own Docker image.

@github-actions github-actions bot added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 31, 2022
@ace-n ace-n mentioned this pull request May 31, 2022
Closed
@ace-n ace-n merged commit 923b9d8 into main May 31, 2022
@ace-n ace-n deleted the terraform-docker branch May 31, 2022 21:18
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grayside grayside grayside approved these changes

Assignees

@ace-n ace-n

Labels
component: delivery Related to automation, testing, deployment of the application. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ace-n @grayside