This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
feat(delivery): document roles used in CI pipeline #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: feature request
ace-n
added
the
do not merge
github-actions
bot
added
type: feature request
grayside
previously requested changes
Jun 7, 2022
terraform/modules/emblem-app/main.tf
Outdated
| ] | ||
| } | ||
|
|
||
| resource "google_project_iam_member" "delivery_storage_object_admin_granting_iam_member" { |
There was a problem hiding this comment.
Why not use google_storage_bucket_iam_member or similar to bind this role to a single bucket without the need for as many conditions?
There was a problem hiding this comment.
EDIT: This is actually a granting permission (permission to grant the storage role), not a storage permission.
AFAICT, this should be kept as-is. 🙂
|
I've confirmed this works (locally) when run with Once this and #482 are merged, I'll confirm this works on a "from-scratch" E2E test run. |
ace-n
removed
the
do not merge
github-actions
bot
added
type: feature request
grayside
approved these changes
Jun 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until this is tested (which requires some other PRs)Fixes #473