Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring changes from dec_2023_release branch into master branch #1530

Merged
merged 8 commits into from Nov 29, 2023
Merged

Bring changes from dec_2023_release branch into master branch #1530

merged 8 commits into from Nov 29, 2023

Conversation

gargnitingoogle
Copy link
Collaborator

Description

This brings in all the changes from dec_2023_release branch to master branch for preparing for December 2023 release.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - presubmit

@gargnitingoogle gargnitingoogle added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Nov 28, 2023
@gargnitingoogle
Copy link
Collaborator Author

@sethiay @ashmeenkaur @Tulsishah please review this PR for your changes.

@gargnitingoogle gargnitingoogle changed the title Bring changes from dec_2023_release branch inoto master branch Bring changes from dec_2023_release branch into master branch Nov 28, 2023
ashmeenkaur
ashmeenkaur previously approved these changes Nov 28, 2023
View reviewed changes
Tulsishah
Tulsishah previously approved these changes Nov 28, 2023
View reviewed changes
@ashmeenkaur ashmeenkaur self-requested a review November 28, 2023 06:50
@gargnitingoogle gargnitingoogle mentioned this pull request Nov 28, 2023
Merged
@gargnitingoogle gargnitingoogle force-pushed the merge_dec_2023_to_master branch 2 times, most recently from 1a7b0ea to 06ec5c4 Compare November 28, 2023 09:06
@gargnitingoogle
Copy link
Collaborator Author

gargnitingoogle commented Nov 28, 2023 •
edited

Integration tests an perf presubmit passed: log

Perf test results:

+--------+------------+--------------+------------+--------------+--------------+
| Branch | File Size | Read BW | Write BW | RandRead BW | RandWrite BW |
+--------+------------+--------------+------------+--------------+--------------+
| Master | 0.25MiB | 446.68MiB/s | 0.98MiB/s | 36.21MiB/s | 0.94MiB/s |
| PR | 0.25MiB | 502.93MiB/s | 1.1MiB/s | 34.15MiB/s | 1.07MiB/s |
| | | | | | |
| | | | | | |
| Master | 48.828MiB | 5096.34MiB/s | 81.1MiB/s | 1184.21MiB/s | 80.25MiB/s |
| PR | 48.828MiB | 4971.74MiB/s | 80.05MiB/s | 1194.0MiB/s | 79.09MiB/s |
| | | | | | |
| | | | | | |
| Master | 976.562MiB | 5121.95MiB/s | 29.1MiB/s | 753.03MiB/s | 33.02MiB/s |
| PR | 976.562MiB | 5008.44MiB/s | 31.95MiB/s | 867.84MiB/s | 31.4MiB/s |
| | | | | | |
| | | | | | |
+--------+------------+--------------+------------+--------------+--------------+

@gargnitingoogle gargnitingoogle removed execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Nov 28, 2023
@gargnitingoogle
Copy link
Collaborator Author

@ashmeenkaur @sethiay made the change you asked for. please approve.

@sethiay
Copy link
Collaborator

sethiay commented Nov 28, 2023

@ashmeenkaur @sethiay made the change you asked for. please approve.

Changes wise looks good to me. @ashmeenkaur please approve after running it on CD pipeline (install test only).

gargnitingoogle and others added 4 commits November 29, 2023 08:57
@gargnitingoogle
Begin Dec 2023 release branch
cd6a36f
@Tulsishah @gargnitingoogle
Remove Image recognition models (#1483)
5ba20df 
* remove animal recognation model

* removing unnecessay models

* delete setup.sh
@Tulsishah @gargnitingoogle
Upgrade go storage pkg from 1.31.0 to 1.34.1 (#1491)
3f3a4f7 
* upgrading go storage pkg

* upgrading go storage pkg

* remove test changes

* test changes

* test changes

* remove test changes
@ashmeenkaur @gargnitingoogle
update install_test.sh to install via the commands mentioned in publi…
de2c6c2 
…c documentation (#1496)
ashmeenkaur and others added 4 commits November 29, 2023 08:59
@ashmeenkaur @gargnitingoogle
add configs for log rotation (#1505)
c66d0ae 
* add configs for log rotation

* review comments

* review comments
@sethiay @gargnitingoogle
Update installation steps for not using apt-key (#1498)
84961c9 
Remove use of apt-key for Ubuntu 21+ and Debian 11+
@ashmeenkaur @gargnitingoogle
Integrate with lumberjack for log rotation (#1504)
ac813f1 
* integrate with lumberjack

* run perf test

* fix fio error

* fix operations tests

* reduce number of  log rotations to reduce integration test execution time

* review comments

* temp commit to run perf tests with trace logs

* fix lint issues

* temp commit

* review comments

* fix lint

* revert perf changes

* refactoring based on review comments
@ashmeenkaur @gargnitingoogle
Rename log rotate config (#1520)
1f5c91e 
* change file-count to backup-file-count

* remove 0 value constraint from backup-file-count

* review comment to add unit test for backup file count 0

* review comments
@ashmeenkaur
Copy link
Collaborator

@ashmeenkaur @sethiay made the change you asked for. please approve.

Changes wise looks good to me. @ashmeenkaur please approve after running it on CD pipeline (install test only).

Done!

@gargnitingoogle
Copy link
Collaborator Author

@sethiay please approve.

sethiay
sethiay approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@sethiay sethiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also get approval from @raj-prince

@gargnitingoogle
Copy link
Collaborator Author

gargnitingoogle commented Nov 29, 2023 •
edited

@raj-prince please review and approve.

Also, after approving, please click rebase and merge for this PR, and then run the long running tests, and update here.

@raj-prince raj-prince merged commit f7a719e into master Nov 29, 2023
8 checks passed
@raj-prince
Copy link
Collaborator

Started the long haul test (tf, pytorch_v2, pytorch_v1_2).

@gargnitingoogle gargnitingoogle deleted the merge_dec_2023_to_master branch November 30, 2023 02:33
@p-linnane p-linnane mentioned this pull request Dec 18, 2023
Merged
@ashmeenkaur ashmeenkaur mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@sethiay sethiay sethiay approved these changes

@ashmeenkaur ashmeenkaur ashmeenkaur approved these changes

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha

@Tulsishah Tulsishah Awaiting requested review from Tulsishah

Assignees

@sethiay sethiay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gargnitingoogle @sethiay @ashmeenkaur @raj-prince @Tulsishah