Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new file to type cache #2303

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Add new file to type cache #2303

merged 6 commits into from
Sep 2, 2024

Conversation

kislaykishore
Copy link
Collaborator

Description

Add new file to type cache

This avoids an additional list call in case of implicit-dirs.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@kislaykishore kislaykishore added the execute-integration-tests Run only integration tests label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.11%. Comparing base (577de7c) to head (9182b37).
Report is 39 commits behind head on master.

Files with missing lines Patch % Lines
internal/fs/inode/base_dir.go 0.00% 4 Missing ⚠️
internal/fs/fs.go 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2303      +/-   ##
==========================================
+ Coverage   79.05%   79.11%   +0.06%     
==========================================
  Files         105      106       +1     
  Lines       11581    11574       -7     
==========================================
+ Hits         9155     9157       +2     
+ Misses       1960     1952       -8     
+ Partials      466      465       -1     
Flag Coverage Δ
unittests 79.11% <73.68%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore marked this pull request as ready for review August 7, 2024 11:37
@kislaykishore kislaykishore requested a review from a team as a code owner August 7, 2024 11:37
@kislaykishore kislaykishore requested review from raj-prince, a team and gargnitingoogle and removed request for a team August 7, 2024 11:37
internal/fs/inode/dir.go Outdated Show resolved Hide resolved
internal/fs/inode/dir.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(a) (Out of scope of this PR) Currently type cache is guarded twice, one with dirInode lock another one with lru lock. We need to remove one.
(b) Can we write a concurrent test, stat and fileCreation.

@kislaykishore kislaykishore force-pushed the new-file-type-cache branch 2 times, most recently from b24ee5c to 60333c6 Compare August 8, 2024 09:06
internal/fs/fs.go Outdated Show resolved Hide resolved
internal/fs/fs.go Outdated Show resolved Hide resolved
internal/fs/inode/dir.go Outdated Show resolved Hide resolved
internal/fs/fs.go Show resolved Hide resolved
internal/fs/inode/base_dir.go Outdated Show resolved Hide resolved
internal/fs/inode/dir_test.go Show resolved Hide resolved
internal/fs/inode/dir_test.go Show resolved Hide resolved
internal/fs/inode/dir_test.go Show resolved Hide resolved
internal/fs/fs.go Outdated Show resolved Hide resolved
internal/fs/fs.go Show resolved Hide resolved
internal/fs/fs.go Outdated Show resolved Hide resolved
internal/fs/inode/base_dir.go Outdated Show resolved Hide resolved
internal/fs/inode/dir.go Outdated Show resolved Hide resolved
internal/fs/local_file_test.go Outdated Show resolved Hide resolved
raj-prince
raj-prince previously approved these changes Aug 27, 2024
@kislaykishore kislaykishore merged commit 3cf1b91 into master Sep 2, 2024
9 of 10 checks passed
@kislaykishore kislaykishore deleted the new-file-type-cache branch September 2, 2024 04:37
kislaykishore added a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants