-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new file to type cache #2303
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2303 +/- ##
==========================================
+ Coverage 79.05% 79.11% +0.06%
==========================================
Files 105 106 +1
Lines 11581 11574 -7
==========================================
+ Hits 9155 9157 +2
+ Misses 1960 1952 -8
+ Partials 466 465 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5e0cbf4
to
d99b87a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(a) (Out of scope of this PR) Currently type cache is guarded twice, one with dirInode lock another one with lru lock. We need to remove one.
(b) Can we write a concurrent test, stat and fileCreation.
b24ee5c
to
60333c6
Compare
tools/integration_tests/concurrent_operations/concurrent_listing_test.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/concurrent_operations/concurrent_listing_test.go
Outdated
Show resolved
Hide resolved
90f3893
to
0e828cd
Compare
de630b1
to
4265014
Compare
4265014
to
d421be3
Compare
tools/integration_tests/concurrent_operations/concurrent_listing_test.go
Outdated
Show resolved
Hide resolved
f3446ab
to
088d5ab
Compare
tools/integration_tests/concurrent_operations/concurrent_listing_test.go
Show resolved
Hide resolved
This reverts commit 3cf1b91.
Description
Add new file to type cache
This avoids an additional list call in case of implicit-dirs.
Link to the issue in case of a bug fix.
NA
Testing details