Cloudshell link fix #20

alekhyal · 2019-03-22T18:23:57Z

No description provided.

googlebot · 2019-03-22T18:24:00Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-03-22T18:24:15Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-03-22T21:43:01Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-03-22T21:46:45Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

bgeesaman

Minor tweaks. Please push a new commit overtop this one with the updates and this is ready.

bgeesaman · 2019-03-22T22:05:59Z

README-QWIKLABS.md

@@ -114,6 +115,13 @@ In the diagram, note:

 ![](./images/istio-gke.png)

+## Run Demo in a Google Cloud Shell
+
+Use `--recursive` argument to download dependencies provided via a git submodule.


Use the --recursive ...

bgeesaman · 2019-03-22T22:06:45Z

README.md

@@ -115,13 +114,14 @@ In the diagram, note:

 ![](./images/istio-gke.png)

+<<<<<<< HEAD


These appear to be left over merge conflict artifacts that shoudl be removed

bgeesaman · 2019-03-22T22:07:00Z

README.md

@@ -132,6 +132,8 @@ gcloud init
 ```

 A Google Cloud account and a project with billing enabled are required for this demo to function. If you do not have a Google Cloud account please sign up for a free trial [here](https://cloud.google.com).
+=======
+>>>>>>> 44f6ab4... Submodule instructions using --recursive


Remove these.

bgeesaman · 2019-03-22T22:07:10Z

README.md

@@ -147,6 +149,12 @@ Click the button below to open the demo in your Cloud Shell:

 [![Open in Cloud Shell](http://gstatic.com/cloudssh/images/open-btn.svg)](https://console.cloud.google.com/cloudshell/open?git_repo=https%3A%2F%2Fgithub.com%2FGoogleCloudPlatform%2Fgke-istio-telemetry-demo&page=editor&tutorial=README.md)

+Use `--recursive` argument to download dependencies provided via a git submodule.


googlebot · 2019-03-23T01:16:27Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-03-23T01:17:12Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-03-23T01:32:12Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-03-23T01:33:14Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

chrislovecnm

/lgtm
/approved

google-oss-robot · 2019-03-24T00:31:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alekhyal, chrislovecnm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [chrislovecnm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chrislovecnm · 2019-03-24T00:31:48Z

@alekhyal you need to rebase and fix the conflicts.

google-oss-robot · 2019-03-25T22:02:01Z

New changes are detected. LGTM label has been removed.

googlebot · 2019-03-25T22:02:04Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-03-25T22:02:25Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

chrislovecnm · 2019-07-05T00:44:25Z

Test this please

google-oss-robot added the gke-helmsman PSO helmsman project label Mar 22, 2019

googlebot added the cla: no No CLA signed label Mar 22, 2019

alekhyal added cla: yes CLA verified and removed cla: no No CLA signed labels Mar 22, 2019

google-oss-robot added the size/XS label Mar 22, 2019

googlebot added cla: no No CLA signed and removed cla: yes CLA verified labels Mar 22, 2019

google-oss-robot added size/S and removed size/XS labels Mar 22, 2019

alekhyal added cla: yes CLA verified and removed cla: no No CLA signed labels Mar 22, 2019

bgeesaman reviewed Mar 22, 2019

View reviewed changes

alekhyal force-pushed the master branch from 985f38f to d882559 Compare March 23, 2019 01:16

googlebot added cla: no No CLA signed and removed cla: yes CLA verified labels Mar 23, 2019

google-oss-robot added size/XS and removed size/S labels Mar 23, 2019

alekhyal added cla: yes CLA verified and removed cla: no No CLA signed labels Mar 23, 2019

update Qwiklabs and Readme instructions

04e038d

alekhyal force-pushed the master branch from d882559 to 04e038d Compare March 23, 2019 01:32

googlebot added cla: no No CLA signed and removed cla: yes CLA verified labels Mar 23, 2019

google-oss-robot added size/L and removed size/XS labels Mar 23, 2019

alekhyal added cla: yes CLA verified and removed cla: no No CLA signed labels Mar 23, 2019

chrislovecnm approved these changes Mar 24, 2019

View reviewed changes

google-oss-robot assigned chrislovecnm Mar 24, 2019

google-oss-robot added the lgtm label Mar 24, 2019

google-oss-robot added the approved label Mar 24, 2019

Merge branch 'master' into master

c4d2265

google-oss-robot removed the lgtm label Mar 25, 2019

googlebot added cla: no No CLA signed and removed cla: yes CLA verified labels Mar 25, 2019

google-oss-robot added size/M and removed size/L labels Mar 25, 2019

alekhyal added cla: yes CLA verified and removed cla: no No CLA signed labels Mar 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cloudshell link fix #20

Cloudshell link fix #20

alekhyal commented Mar 22, 2019

googlebot commented Mar 22, 2019

googlebot commented Mar 22, 2019

googlebot commented Mar 22, 2019

googlebot commented Mar 22, 2019

bgeesaman left a comment

bgeesaman Mar 22, 2019

bgeesaman Mar 22, 2019

bgeesaman Mar 22, 2019

bgeesaman Mar 22, 2019

googlebot commented Mar 23, 2019

googlebot commented Mar 23, 2019

googlebot commented Mar 23, 2019

googlebot commented Mar 23, 2019

chrislovecnm left a comment

google-oss-robot commented Mar 24, 2019

chrislovecnm commented Mar 24, 2019

google-oss-robot commented Mar 25, 2019

googlebot commented Mar 25, 2019

googlebot commented Mar 25, 2019

chrislovecnm commented Jul 5, 2019

		@@ -115,13 +114,14 @@ In the diagram, note:

		![](./images/istio-gke.png)

		<<<<<<< HEAD

		@@ -147,6 +149,12 @@ Click the button below to open the demo in your Cloud Shell:

		[![Open in Cloud Shell](http://gstatic.com/cloudssh/images/open-btn.svg)](https://console.cloud.google.com/cloudshell/open?git_repo=https%3A%2F%2Fgithub.com%2FGoogleCloudPlatform%2Fgke-istio-telemetry-demo&page=editor&tutorial=README.md)

		Use `--recursive` argument to download dependencies provided via a git submodule.

Cloudshell link fix #20

Are you sure you want to change the base?

Cloudshell link fix #20

Conversation

alekhyal commented Mar 22, 2019

googlebot commented Mar 22, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Mar 22, 2019

googlebot commented Mar 22, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Mar 22, 2019

bgeesaman left a comment

Choose a reason for hiding this comment

bgeesaman Mar 22, 2019

Choose a reason for hiding this comment

bgeesaman Mar 22, 2019

Choose a reason for hiding this comment

bgeesaman Mar 22, 2019

Choose a reason for hiding this comment

bgeesaman Mar 22, 2019

Choose a reason for hiding this comment

googlebot commented Mar 23, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Mar 23, 2019

googlebot commented Mar 23, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Mar 23, 2019

chrislovecnm left a comment

Choose a reason for hiding this comment

google-oss-robot commented Mar 24, 2019

chrislovecnm commented Mar 24, 2019

google-oss-robot commented Mar 25, 2019

googlebot commented Mar 25, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Mar 25, 2019

chrislovecnm commented Jul 5, 2019