Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

Update CFT templates #16

Open
chrislovecnm opened this issue Aug 29, 2019 · 1 comment
Open

Update CFT templates #16

chrislovecnm opened this issue Aug 29, 2019 · 1 comment

Comments

@chrislovecnm
Copy link
Contributor

In order to use CFT we need to update the various files in https://github.com/GoogleCloudPlatform/gke-terraform-generator/tree/master/pkg/terraform/cft

Each of the files needs to be updated to support the various values set in https://github.com/GoogleCloudPlatform/gke-terraform-generator/blob/master/pkg/api/api.go. Those structs define the values that the user provides in the yaml that is used to define a cluster.

The https://github.com/GoogleCloudPlatform/gke-terraform-generator/tree/master/pkg/terraform/vanilla directory containers the currently working templates for vanilla terraform that can be used as a guide on how to implement the CFT terraform.

The CFT go templates, to my best recollection, where working at one point, but need to be improved and tested.

Tests like https://github.com/GoogleCloudPlatform/gke-terraform-generator/blob/master/pkg/templates/templates_test.go#L82 determine if various values are set in the templates. Further unit testing should be implemented.

@chrislovecnm
Copy link
Contributor Author

Also

gke-tf -t CFT -f my-example.yaml will create CFT based terraform. It already will work, but the templates need updating.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant