adding java8 spanner sample #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabubake
added
the
do not merge
googlebot
added
the
cla: yes
jabubake
removed
the
do not merge
lesv
suggested changes
Jun 15, 2017
appengine-java8/spanner/README.md
Outdated
| A database will created using the `SPANNER_DATABASE` name if provided, else will be auto-generated. | ||
|
|
||
| ## Endpoints | ||
| - `/run` : will run sample operations against the spanner instance in order. Individual tasks can be run |
appengine-java8/spanner/README.md
Outdated
| - Update system properties in `[appengine-web.xml](src/main/webapp/WEB-INF/appengine-web.xml): | ||
| - Required : `SPANNER_INSTANCE` | ||
| - Optional : `SPANNER_DATABASE`, | ||
| A database will created using the `SPANNER_DATABASE` name if provided, else will be auto-generated. |
There was a problem hiding this comment.
I cleaned up to be just SPANNER_INSTANCE so its clearer.
appengine-java8/spanner/README.md
Outdated
| You may also [create and use service account credentials](https://cloud.google.com/docs/authentication/getting-started#creating_the_service_account). | ||
| - To run locally, we will be using the [Maven Jetty plugin](http://www.eclipse.org/jetty/documentation/9.4.x/jetty-maven-plugin.html) | ||
| ``` | ||
| mvn -DSPANNER_INSTANCE=my-spanner-instance jetty:run |
There was a problem hiding this comment.
Let's not tell them this - it's not really for J8 Std
There was a problem hiding this comment.
THIS IS TEMPORARY - explain why and the issue # they can follow.
There was a problem hiding this comment.
Added tracking issue.
appengine-java8/spanner/pom.xml
Outdated
| <plugins> | ||
| <plugin> | ||
| <groupId>org.eclipse.jetty</groupId> | ||
| <artifactId>jetty-maven-plugin</artifactId> |
There was a problem hiding this comment.
Actually, just comment that this is hear due to a problem in the spanner library that we can't run locally under normal tooling -- GAE development server - GAE API's won't work here.
| import javax.servlet.ServletContextListener; | ||
| import javax.servlet.annotation.WebListener; | ||
|
|
||
| @WebListener |
There was a problem hiding this comment.
We like having comments about why this makes it so that we don't use web.xml
| * Individual tasks can be run using "tasks" query parameter. {@link SpannerTasks.Task} lists | ||
| * supported tasks. All tasks are run in order if no parameter or "tasks=all" is provided. | ||
| */ | ||
| @WebServlet(value = "/run") |
There was a problem hiding this comment.
/spanner - also comment on why this keeps you from needing a web.xml
There was a problem hiding this comment.
renamed to /spanner & added comment about annotation
|
@lesv PTAL |
lesv
approved these changes
Jun 15, 2017
averikitsch
pushed a commit
that referenced
this pull request
Oct 27, 2022
…to v0.9.13 (#711) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.graalvm.buildtools:junit-platform-native](https://togithub.com/graalvm/native-build-tools) | `0.9.12` -> `0.9.13` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>graalvm/native-build-tools</summary> ### [`v0.9.13`](https://togithub.com/graalvm/native-build-tools/releases/tag/0.9.13) [Compare Source](https://togithub.com/graalvm/native-build-tools/compare/0.9.12...0.9.13) ##### What's Changed Read what's new in the [documentation](https://graalvm.github.io/native-build-tools/latest/index.html#changelog). - Restore `NativeImagePlugin.NATIVE_TEST_EXTENSION` by [@​lazar-mitrovic](https://togithub.com/lazar-mitrovic) in [https://github.com/graalvm/native-build-tools/pull/256](https://togithub.com/graalvm/native-build-tools/pull/256) - Fix JUnit annotation scanning during the image build by [@​gradinac](https://togithub.com/gradinac) in [https://github.com/graalvm/native-build-tools/pull/258](https://togithub.com/graalvm/native-build-tools/pull/258) - Change reachability metadata fallback path by [@​lazar-mitrovic](https://togithub.com/lazar-mitrovic) in [https://github.com/graalvm/native-build-tools/pull/257](https://togithub.com/graalvm/native-build-tools/pull/257) - Add a DSL option that enables the native-image agent by [@​gradinac](https://togithub.com/gradinac) in [https://github.com/graalvm/native-build-tools/pull/263](https://togithub.com/graalvm/native-build-tools/pull/263) - Bump dependency versions by [@​lazar-mitrovic](https://togithub.com/lazar-mitrovic) in [https://github.com/graalvm/native-build-tools/pull/264](https://togithub.com/graalvm/native-build-tools/pull/264) - Rename `jvm-reachability-metadata` -> `graalvm-reachability-metadata` by [@​melix](https://togithub.com/melix) in [https://github.com/graalvm/native-build-tools/pull/265](https://togithub.com/graalvm/native-build-tools/pull/265) - Final PR for the metadata repo by [@​vjovanov](https://togithub.com/vjovanov) in [https://github.com/graalvm/native-build-tools/pull/266](https://togithub.com/graalvm/native-build-tools/pull/266) ##### New Contributors - [@​vjovanov](https://togithub.com/vjovanov) made their first contribution in [https://github.com/graalvm/native-build-tools/pull/266](https://togithub.com/graalvm/native-build-tools/pull/266) **Full Changelog**: graalvm/native-build-tools@0.9.12...0.9.13 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-tasks).
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 14, 2022
…711) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.1.3` -> `2.1.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.1.4`](https://togithub.com/googleapis/java-core/blob/master/CHANGELOG.md#​214-httpswwwgithubcomgoogleapisjava-corecomparev213v214-2021-09-15) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.1.3...v2.1.4) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
](https://renovatebot.com){kind=link}
…711) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.1.3` -> `2.1.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.1.4`](https://togithub.com/googleapis/java-core/blob/master/CHANGELOG.md#​214-httpswwwgithubcomgoogleapisjava-corecomparev213v214-2021-09-15) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.1.3...v2.1.4) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
…1.0 (#711) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `24.0.0` -> `24.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai).
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
…1.0 (#711) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `24.0.0` -> `24.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spanner app engine sample.
FYI, @ludoch