Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dependency to GAE app #8660

Closed
wants to merge 1 commit into from
Closed

fix: add dependency to GAE app #8660

wants to merge 1 commit into from

Conversation

averikitsch
Copy link
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Sep 20, 2023
@averikitsch averikitsch linked an issue Sep 20, 2023 that may be closed by this pull request
@ludoch
Copy link
Contributor

ludoch commented Sep 20, 2023

This is scary, as customers should not be force to handle these dependencies

I suspect a regression with 592e9e8 ?
Did you try our fix is working, or moving to previous SDK version removes this regression?

On my side, I will try to understand what's going one.

@averikitsch
Copy link
Contributor Author

This is scary, as customers should not be force to handle these dependencies

I suspect a regression with 592e9e8 ? Did you try our fix is working, or moving to previous SDK version removes this regression?

On my side, I will try to understand what's going one.

I have tried the previous versions without success. It needs either this dependency or

<dependency>
      <groupId>org.eclipse.jetty</groupId>
      <artifactId>apache-jsp</artifactId>
      <version>9.4.52.v20230823</version>
      <scope>provided</scope>
  </dependency>

@averikitsch averikitsch added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 21, 2023
@averikitsch averikitsch deleted the akitsch-gae-dep branch October 23, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: appengine Issues related to the App Engine Admin API API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hello World app not working on appengine java8
3 participants