Add Managed Kafka Cluster resource and tests #10773

jessdejong · 2024-05-23T04:50:56Z

Description: Adding a new Managed Kafka Cluster terraform resource to terraform-provider-google-beta. Includes a basic create, basic update, and CMEK test.

Issue: https://b.corp.google.com/issues/322841720

`google_managed_kafka_cluster` (beta)

github-actions · 2024-05-29T12:22:37Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-05-31T16:43:15Z

Tests analytics

Total tests: 3731
Passed tests: 3350
Skipped tests: 373
Affected tests: 8

Click here to see the affected service packages

all service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComposer1Environment_withNodeConfig|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccManagedKafkaCluster_managedkafkaClusterCmekExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

modular-magician · 2024-05-31T17:35:26Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccManagedKafkaCluster_managedkafkaClusterCmekExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComposer1Environment_withNodeConfig[Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeInstance_guestAccelerator[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

slevenick

Couple minor questions, overall looks fine

mmv1/products/managedkafka/Cluster.yaml

mmv1/templates/terraform/examples/managedkafka_cluster_cmek.tf.erb

modular-magician · 2024-06-03T16:14:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 303 insertions(+))
google-beta provider: Diff ( 13 files changed, 1740 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 226 insertions(+))

modular-magician · 2024-06-03T17:12:53Z

Tests analytics

Total tests: 3738
Passed tests: 3345
Skipped tests: 376
Affected tests: 17

Click here to see the affected service packages

all service packages are affected

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_update|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_webhook_config|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_secretMount|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudRunService_secretVolume|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator|TestAccIntegrationConnectorsConnection|TestAccIntegrationConnectorsEndpointAttachment_integrationConnectorsEndpointAttachmentExample_update|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

modular-magician · 2024-06-03T17:50:31Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Debug log]
TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample[Debug log]
TestAccCloudBuildTrigger_webhook_config[Debug log]
TestAccCloudFunctionsFunction_secretEnvVar[Debug log]
TestAccCloudFunctionsFunction_secretMount[Debug log]
TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample[Debug log]
TestAccCloudRunService_cloudRunServiceSecretVolumesExample[Debug log]
TestAccCloudRunService_secretEnvironmentVariable[Debug log]
TestAccCloudRunService_secretVolume[Debug log]
TestAccIntegrationConnectorsEndpointAttachment_integrationConnectorsEndpointAttachmentExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeInstance_guestAccelerator[Error message] [Debug log]
TestAccIntegrationConnectorsConnection[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

github-actions · 2024-06-05T09:40:01Z

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

slevenick · 2024-06-05T16:32:25Z

/gcbrun hopefully some more of these tests will be fixed. They're unrelated so I'll merge without them all passing

slevenick

LGTM!

modular-magician · 2024-06-05T16:44:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 303 insertions(+))
google-beta provider: Diff ( 13 files changed, 1740 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 226 insertions(+))

modular-magician · 2024-06-05T17:43:45Z

Tests analytics

Total tests: 3753
Passed tests: 3339
Skipped tests: 378
Affected tests: 36

Click here to see the affected service packages

all service packages are affected

Action taken

Found 36 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_update|TestAccApphubWorkload_apphubWorkloadBasicExample|TestAccApphubWorkload_apphubWorkloadFullExample|TestAccApphubWorkload_apphubWorkloadUpdate|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeInstanceGroup_rename|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstanceTemplate_sourceImageEncryptionKey|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccDataSourceApphubDiscoveredWorkload_basic|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_versions|TestAccIntegrationConnectorsConnection|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample|TestAccNetworkServicesLbRouteExtension_update|TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample|TestAccNetworkServicesLbTrafficExtension_update|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_versions|TestAccTags|TestAccTagsLocationTagBinding_locationTagBindingzonal|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

modular-magician · 2024-06-05T18:56:11Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Debug log]
TestAccApphubWorkload_apphubWorkloadBasicExample[Debug log]
TestAccApphubWorkload_apphubWorkloadFullExample[Debug log]
TestAccApphubWorkload_apphubWorkloadUpdate[Debug log]
TestAccComputeBackendService_withBackendAndIAP[Debug log]
TestAccComputeInstanceGroup_rename[Debug log]
TestAccComputeInstanceTemplate_sourceImageEncryptionKey[Debug log]
TestAccComputePerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccComputePerInstanceConfig_statefulIps[Debug log]
TestAccComputePerInstanceConfig_update[Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccDataSourceApphubDiscoveredWorkload_basic[Debug log]
TestAccInstanceGroupManager_resourceManagerTags[Debug log]
TestAccInstanceGroupManager_targetSizeZero[Debug log]
TestAccInstanceGroupManager_versions[Debug log]
TestAccIntegrationConnectorsConnection[Debug log]
TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample[Debug log]
TestAccNetworkManagementConnectivityTest_update[Debug log]
TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample[Debug log]
TestAccNetworkServicesLbRouteExtension_update[Debug log]
TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample[Debug log]
TestAccNetworkServicesLbTrafficExtension_update[Debug log]
TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample[Debug log]
TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample[Debug log]
TestAccRegionInstanceGroupManager_distributionPolicy[Debug log]
TestAccRegionInstanceGroupManager_resourceManagerTags[Debug log]
TestAccRegionInstanceGroupManager_stateful[Debug log]
TestAccRegionInstanceGroupManager_targetSizeZero[Debug log]
TestAccRegionInstanceGroupManager_versions[Debug log]
TestAccTags[Debug log]
TestAccTagsLocationTagBinding_locationTagBindingzonal[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-06-05T22:13:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 293 insertions(+))
google-beta provider: Diff ( 13 files changed, 1720 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 226 insertions(+))

modular-magician · 2024-06-05T23:10:43Z

Tests analytics

Total tests: 3755
Passed tests: 3370
Skipped tests: 379
Affected tests: 6

Click here to see the affected service packages

all service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

modular-magician · 2024-06-05T23:41:18Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

github-actions · 2024-06-07T09:39:54Z

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

…form#10773)" This reverts commit 46fd4d3.

jessdejong added 2 commits May 23, 2024 00:16

Add cluster resource and tests.

b89fd6f

Remove topic resource and tests.

f1783ed