Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize disk in google_workbench_instance resource #10972

Merged
merged 28 commits into from
Jun 18, 2024

Conversation

bcreddy-gcp
Copy link
Contributor

@bcreddy-gcp bcreddy-gcp commented Jun 16, 2024

fixes b/338962537

Release Note Template for Downstream PRs (will be copied)

workbench: added update support to `gce_setup.boot_disk` and `gce_setup.data_disks` fields in `google_workbench_instance` resource

@github-actions github-actions bot requested a review from zli82016 June 16, 2024 18:37
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@bcreddy-gcp
Copy link
Contributor Author

#10933

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 204 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 204 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 204 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 204 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 204 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 204 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 15
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • workbench

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkbenchInstance_update|TestAccWorkbenchInstance_updateBootDisk|TestAccWorkbenchInstance_updateBothDisks|TestAccWorkbenchInstance_updateDataDisk

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 15
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • workbench

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkbenchInstance_update|TestAccWorkbenchInstance_updateBootDisk|TestAccWorkbenchInstance_updateBothDisks|TestAccWorkbenchInstance_updateDataDisk

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_updateBootDisk[Error message] [Debug log]
TestAccWorkbenchInstance_updateBothDisks[Error message] [Debug log]
TestAccWorkbenchInstance_updateDataDisk[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_updateBootDisk[Error message] [Debug log]
TestAccWorkbenchInstance_updateBothDisks[Error message] [Debug log]
TestAccWorkbenchInstance_updateDataDisk[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 16
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • workbench

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkbenchInstance_update|TestAccWorkbenchInstance_updateBootDisk|TestAccWorkbenchInstance_updateBothDisks|TestAccWorkbenchInstance_updateDataDisk

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_updateBootDisk[Error message] [Debug log]
TestAccWorkbenchInstance_updateBothDisks[Error message] [Debug log]
TestAccWorkbenchInstance_updateDataDisk[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 229 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 229 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 17
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • workbench

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkbenchInstance_updateBootDisk|TestAccWorkbenchInstance_updateBothDisks|TestAccWorkbenchInstance_updateDataDisk

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkbenchInstance_updateBootDisk[Debug log]
TestAccWorkbenchInstance_updateBothDisks[Debug log]
TestAccWorkbenchInstance_updateDataDisk[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@zli82016
Copy link
Member

/gcbrun

@zli82016
Copy link
Member

Is there a Github issue or Buganizer issue for this PR? If yes, can you please add it to the description section of this PR? Thanks.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 229 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 229 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • workbench

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@bcreddy-gcp
Copy link
Contributor Author

b/338962537

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 227 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 227 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 35 insertions(+))

@github-actions github-actions bot requested a review from zli82016 June 18, 2024 18:14
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • workbench

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 229 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 229 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • workbench

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@zli82016
Copy link
Member

zli82016 commented Jun 18, 2024

LGTM. One minor issue is that there are 28 commits for this PR, which could cause merging to main branch fail. Is it easy to combine all of the commits to one?

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 changed the title Wbi resize disk Resize disk in google_workbench_instance resource Jun 18, 2024
@zli82016 zli82016 merged commit ade0a1e into GoogleCloudPlatform:main Jun 18, 2024
14 checks passed
@bcreddy-gcp bcreddy-gcp deleted the wbi_resize branch June 18, 2024 19:50
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 24, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
vijaykanthm pushed a commit to vijaykanthm/magic-modules that referenced this pull request Jul 22, 2024
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants