Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified docs around compute instance networking #5269

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

melinath
Copy link
Member

@melinath melinath commented Oct 1, 2021

Related to hashicorp/terraform-provider-google#10133. Made docs for networking more closely match each other & https://cloud.google.com/compute/docs/reference/rest/v1/instances

Release Note Template for Downstream PRs (will be copied)


@melinath melinath requested review from a team and c2thorn and removed request for a team October 1, 2021 21:27
@google-cla google-cla bot added the cla: yes label Oct 1, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 8 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=208702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants