Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TABLE_VALUED_FUNCTION and returnTableType to bigquery_routine #5489

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Conversation

Tei1988
Copy link
Contributor

@Tei1988 Tei1988 commented Nov 25, 2021

Add TABLE_VALUED_FUNCTION and returnTableType to bigquery#routine.

This PR is contributes to hashicorp/terraform-provider-google#10120 .

I just tested to create a table valued function using local built provider.
But I can not run acceptance tests.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: added `TABLE_VALUED_FUNCTION` to routine_type on resource `bigquery_routine`
bigquery: added field `return_table_type` to resource `bigquery_routine`

@google-cla google-cla bot added the cla: yes label Nov 25, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 141 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 141 insertions(+), 3 deletions(-))
TF Validator: Diff ( 1 file changed, 18 insertions(+))
TF OiCS: Diff ( 4 files changed, 122 insertions(+))

@rileykarson
Copy link
Member

Running tests! The first pass will have the new test fail, but the second should succeed.

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 159 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 3 files changed, 141 insertions(+), 3 deletions(-))
TF Validator: Diff ( 1 file changed, 18 insertions(+))
TF OiCS: Diff ( 4 files changed, 122 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 141 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 141 insertions(+), 3 deletions(-))
TF Validator: Diff ( 1 file changed, 18 insertions(+))
TF OiCS: Diff ( 4 files changed, 122 insertions(+))

@Tei1988
Copy link
Contributor Author

Tei1988 commented Dec 4, 2021

@rileykarson
Thank you for running tests.

I'm not sure what should I do after this.
Should I fix something ?

@rileykarson
Copy link
Member

Hmm, seems they didn't get posted. Let me try again.

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 141 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 141 insertions(+), 3 deletions(-))
TF Validator: Diff ( 1 file changed, 18 insertions(+))
TF OiCS: Diff ( 4 files changed, 122 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccBigQueryRoutine_bigQueryRoutineTvfExample|TestAccCloudFunctionsFunction_basic|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_ephemeralStorageConfig|TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample|TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccPrivatecaCertificate_privatecaCertificateConfigExample|TestAccPrivatecaCertificate_privatecaCertificateCsrExample|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=229412

@Tei1988
Copy link
Contributor Author

Tei1988 commented Dec 13, 2021

@rileykarson
Thank you for rerunning tests.

Does this fail mean the first pass you said before?
I tried to check the above url, but It seems that I can't access it.

@rileykarson
Copy link
Member

Yep- I can see the logs, and TestAccBigQueryRoutine_bigQueryRoutineTvfExample passed on the second run. Everything else in that list are false positives, effectively.

Note: TFV failures are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants