chore: update config for metrics purposes #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NimJay
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Thanks, @tpryan, for continually supporting the "Online Boutique via DeployStack" user journey!
Approved.
This sounds like a very DeployStack-specific change, so I don't expect Online Boutique maintainers (including myself) to understand the details. I'll share this old comment of mine for any Online Boutique maintainer that might have the same idea.
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Cannot record metric impact of running this through Deploystack - no way to count api usage without this string in the config file
Change Summary
Added a line to the deploystack config to make sure that these calls are labeled properly in our systems. This is a super minimal fix that only affects how this stack's deployments are metricked.