Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden containers with securityContext #887

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Harden containers with securityContext #887

merged 1 commit into from
Jun 21, 2022

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Jun 20, 2022 •
edited
Loading

Following up on what was done with cartservice: #848, now with the rest of the services.

Update the Kubernetes manifest of any Deployments with securityContext features

  • CI tests
  • Tests on my GKE cluster
  • Tests on my GKE cluster with ASM

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner June 20, 2022 14:13
@mathieu-benoit mathieu-benoit marked this pull request as draft June 20, 2022 14:13
@github-actions
Copy link

🚲 PR staged at http://34.66.112.205

@mathieu-benoit mathieu-benoit marked this pull request as ready for review June 20, 2022 15:36
@mathieu-benoit
Copy link
Contributor Author

Ready for your review, thanks!

xtineskim
xtineskim approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@xtineskim xtineskim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - maybe @NimJay should stamp before merging

NimJay
NimJay approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome.
All checks are passing.
You've covered all services (except the already-covered cartservice).
Approved.

@NimJay NimJay changed the title Unprivileged containers Harden containers with securityContext Jun 21, 2022
@NimJay NimJay merged commit b3debab into main Jun 21, 2022
@NimJay NimJay deleted the mathieu-benoit/unprivileged-containers branch June 21, 2022 13:00
@mathieu-benoit mathieu-benoit mentioned this pull request Jun 21, 2022
Merged
4 tasks
@mathieu-benoit mathieu-benoit mentioned this pull request Sep 14, 2022
Merged
This was referenced Oct 19, 2022
Closed
Merged
Merged
@NimJay NimJay mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtineskim xtineskim xtineskim approved these changes

@NimJay NimJay NimJay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathieu-benoit @NimJay @xtineskim