Expose more conntrack-related error as metrics #211
Conversation
|
Expose more conntrack-related error as metrics. |
|
I'm thinking if we should still permute all metrics like this as the list grows, or switch to a map potentially with an allowlist to capture all metrics. @MrHohn thoughts? |
In this case I won't expect the list to grow in a significant way - these are the conntrack stats that exist for years. So I'm fine with anything simple here. |
|
/lgtm |
| } | ||
| } | ||
| if indices.insertFailed == -1 || indices.drop == -1 { | ||
| if indices.found == -1 || indices.invalid == -1 || |
There was a problem hiding this comment.
Looks like this won't work as we didn't explicitly assign the other fields -1 initially?
There was a problem hiding this comment.
Done. Set all the indices to -1 before this judgment.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, yiningou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.