ci: regenerate workflows with updated template #3143
Conversation
product-auto-label
bot
added
samples
…docs-samples into update-workflows
There was a problem hiding this comment.
LGTM with a comment re: IAM.
One more clarification - do we need to regenerate workflows with every new folder added to this repository? If yes, then we should add this information in the contributors documentation and PR template to make sure people remember about it.
| @@ -23,7 +23,7 @@ const iamClient = new PoliciesClient(); | |||
|
|
|||
| const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'}); | |||
|
|
|||
| describe('IAM deny samples', () => { | |||
| describe.skip('IAM deny samples', () => { | |||
There was a problem hiding this comment.
I have updated service account permissions and this test should pass now. Please double check.
There was a problem hiding this comment.
Thanks! Retrying now.
There was a problem hiding this comment.
I tried again and still received a failure message:
PERMISSION_DENIED: Permission iam.googleapis.com/denypolicies.create denied on resource cloudresourcemanager.googleapis.com/projects/long-door-651
Will revert and we can handle this separately. It should work, thanks for trying here.
No, it is not necessary to regenerate all workflows. Contributors just need to add an entry to |
[Per discussion](#3143 (comment)) we should make sure that users don't miss workflow generation when creating a new folder. Moreover a missing CODEOWNERS step was added here as well.
[Per discussion](#3143 (comment)) we should make sure that users don't miss workflow generation when creating a new folder. Moreover a missing CODEOWNERS step was added here as well. Co-authored-by: Karl Weinmeister <11586922+kweinmeister@users.noreply.github.com>
Updated existing workflows to use common template from #3079 and #3112.
In the process, added multiple workflows for samples that haven't been tested. See
.github/workflows/utils/workflows.jsonchanges.There are a couple blocking tests that were skipped. There are open issues to resolve these: #3121 and #3117; and new issues created: #3144 and #3153.