Travis: fix failing tests + update dependencies #335

ace-n · 2017-04-04T21:28:10Z

No description provided.

ace-n · 2017-04-05T18:27:31Z

This doesn't fix everything, and leaves a number of TODOs:

Monitoring tests are flaky (and need fixing)
DLP tests should be parallelized
The node-mailer module only works with v6+ of Node - we need a different module, since we support v4.
It seems like we're currently skipping a bunch of App Engine tests. IMHO, we need to either fix those tests, or remove the associated samples.

However, it does fix some more egregious test failures.

ace-n · 2017-04-05T18:28:54Z

/cc @jmdobry as FYI.

theacodes · 2017-04-05T19:33:23Z

monitoring/system-test/quickstart.test.js

@@ -23,7 +23,8 @@ const client = proxyquire(`@google-cloud/monitoring`, {}).v3().metricServiceClie
 test.beforeEach(stubConsole);
 test.afterEach.always(restoreConsole);

-test.cb(`should list time series`, (t) => {
+// TODO(anassri): Fix this test occasionally omitting time series data


Don't put TODOs in code, you have two world-class bug tracking tools at your disposal.

This reverts commit b7259c8.

@gguuss

* Make unify script recursive + clean up dependency conflicts * Restore travis.yml * Delete outdated text detection sample that duplicates detect.js * Fix failing KMS + vision tests by updating dependencies * Fix video tests using a bad cwd * Upgrade monitoring dependency + skip flaky monitoring tests * Fix DLP tests having wrong cwd * Fix failing vision test * Fix datastore tests * Update broken dependency * Update possibly broken compute engine dependency * Fix typos * Disable Node 4 testing * Revert deletion of outdated sample - @gguuss says we still use this. This reverts commit b7259c8. * Update dependency

🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.3](https://www.github.com/googleapis/nodejs-talent/compare/v3.2.2...v3.2.3) (2021-06-22) ### Bug Fixes * make request optional in all cases ([#335](https://www.github.com/googleapis/nodejs-talent/issues/335)) ([7ba1f51](https://www.github.com/googleapis/nodejs-talent/commit/7ba1f51db25cf37b33f9a611e031c7294112649a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…her languages. (#335)

@gguuss

* Make unify script recursive + clean up dependency conflicts * Restore travis.yml * Delete outdated text detection sample that duplicates detect.js * Fix failing KMS + vision tests by updating dependencies * Fix video tests using a bad cwd * Upgrade monitoring dependency + skip flaky monitoring tests * Fix DLP tests having wrong cwd * Fix failing vision test * Fix datastore tests * Update broken dependency * Update possibly broken compute engine dependency * Fix typos * Disable Node 4 testing * Revert deletion of outdated sample - @gguuss says we still use this. This reverts commit b7259c8. * Update dependency

…her languages. (#335)

@gguuss

* Make unify script recursive + clean up dependency conflicts * Restore travis.yml * Delete outdated text detection sample that duplicates detect.js * Fix failing KMS + vision tests by updating dependencies * Fix video tests using a bad cwd * Upgrade monitoring dependency + skip flaky monitoring tests * Fix DLP tests having wrong cwd * Fix failing vision test * Fix datastore tests * Update broken dependency * Update possibly broken compute engine dependency * Fix typos * Disable Node 4 testing * Revert deletion of outdated sample - @gguuss says we still use this. This reverts commit b7259c8. * Update dependency

@gguuss

* Make unify script recursive + clean up dependency conflicts * Restore travis.yml * Delete outdated text detection sample that duplicates detect.js * Fix failing KMS + vision tests by updating dependencies * Fix video tests using a bad cwd * Upgrade monitoring dependency + skip flaky monitoring tests * Fix DLP tests having wrong cwd * Fix failing vision test * Fix datastore tests * Update broken dependency * Update possibly broken compute engine dependency * Fix typos * Disable Node 4 testing * Revert deletion of outdated sample - @gguuss says we still use this. This reverts commit b7259c8. * Update dependency

@gguuss

* Make unify script recursive + clean up dependency conflicts * Restore travis.yml * Delete outdated text detection sample that duplicates detect.js * Fix failing KMS + vision tests by updating dependencies * Fix video tests using a bad cwd * Upgrade monitoring dependency + skip flaky monitoring tests * Fix DLP tests having wrong cwd * Fix failing vision test * Fix datastore tests * Update broken dependency * Update possibly broken compute engine dependency * Fix typos * Disable Node 4 testing * Revert deletion of outdated sample - @gguuss says we still use this. This reverts commit b7259c8. * Update dependency

@gguuss

* Make unify script recursive + clean up dependency conflicts * Restore travis.yml * Delete outdated text detection sample that duplicates detect.js * Fix failing KMS + vision tests by updating dependencies * Fix video tests using a bad cwd * Upgrade monitoring dependency + skip flaky monitoring tests * Fix DLP tests having wrong cwd * Fix failing vision test * Fix datastore tests * Update broken dependency * Update possibly broken compute engine dependency * Fix typos * Disable Node 4 testing * Revert deletion of outdated sample - @gguuss says we still use this. This reverts commit b7259c8. * Update dependency

@gguuss

* Make unify script recursive + clean up dependency conflicts * Restore travis.yml * Delete outdated text detection sample that duplicates detect.js * Fix failing KMS + vision tests by updating dependencies * Fix video tests using a bad cwd * Upgrade monitoring dependency + skip flaky monitoring tests * Fix DLP tests having wrong cwd * Fix failing vision test * Fix datastore tests * Update broken dependency * Update possibly broken compute engine dependency * Fix typos * Disable Node 4 testing * Revert deletion of outdated sample - @gguuss says we still use this. This reverts commit b7259c8. * Update dependency

@gguuss

* Make unify script recursive + clean up dependency conflicts * Restore travis.yml * Delete outdated text detection sample that duplicates detect.js * Fix failing KMS + vision tests by updating dependencies * Fix video tests using a bad cwd * Upgrade monitoring dependency + skip flaky monitoring tests * Fix DLP tests having wrong cwd * Fix failing vision test * Fix datastore tests * Update broken dependency * Update possibly broken compute engine dependency * Fix typos * Disable Node 4 testing * Revert deletion of outdated sample - @gguuss says we still use this. This reverts commit b7259c8. * Update dependency

@gguuss

* Make unify script recursive + clean up dependency conflicts * Restore travis.yml * Delete outdated text detection sample that duplicates detect.js * Fix failing KMS + vision tests by updating dependencies * Fix video tests using a bad cwd * Upgrade monitoring dependency + skip flaky monitoring tests * Fix DLP tests having wrong cwd * Fix failing vision test * Fix datastore tests * Update broken dependency * Update possibly broken compute engine dependency * Fix typos * Disable Node 4 testing * Revert deletion of outdated sample - @gguuss says we still use this. This reverts commit b7259c8. * Update dependency

@gguuss

* Make unify script recursive + clean up dependency conflicts * Restore travis.yml * Delete outdated text detection sample that duplicates detect.js * Fix failing KMS + vision tests by updating dependencies * Fix video tests using a bad cwd * Upgrade monitoring dependency + skip flaky monitoring tests * Fix DLP tests having wrong cwd * Fix failing vision test * Fix datastore tests * Update broken dependency * Update possibly broken compute engine dependency * Fix typos * Disable Node 4 testing * Revert deletion of outdated sample - @gguuss says we still use this. This reverts commit b7259c8. * Update dependency

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

Ace Nassri added 14 commits March 31, 2017 16:38

Make unify script recursive + clean up dependency conflicts

edf4764

Restore travis.yml

ed8c01e

Delete outdated text detection sample that duplicates detect.js

b7259c8

Fix failing KMS + vision tests by updating dependencies

afc4411

Fix video tests using a bad cwd

f95c9b4

Upgrade monitoring dependency + skip flaky monitoring tests

74b875c

Fix DLP tests having wrong cwd

02d459a

Fix failing vision test

3db774b

Fix datastore tests

b27461f

Update broken dependency

bf2e265

Update possibly broken compute engine dependency

59361b5

Merge branch 'master' into fix-travis

25e5b35

Fix typos

40dbc75

Disable Node 4 testing

e841f52

ace-n changed the title ~~[DO NOT MERGE - yet] Travis: fix failing tests + update dependencies~~ Travis: fix failing tests + update dependencies Apr 5, 2017

ace-n requested a review from theacodes April 5, 2017 18:28

theacodes reviewed Apr 5, 2017

View reviewed changes

theacodes approved these changes Apr 5, 2017

View reviewed changes

Ace Nassri added 2 commits April 5, 2017 13:16

Revert deletion of outdated sample - @gguuss says we still use this.

beda91a

This reverts commit b7259c8.

Update dependency

30b2244

ace-n merged commit 1e17f80 into master Apr 5, 2017

ace-n deleted the fix-travis branch April 7, 2017 21:47

snyk-bot mentioned this pull request Mar 11, 2022

[Snyk] Upgrade @google-cloud/debug-agent from 2.4.0 to 2.6.0 theWindSweptDev/nodejs-docs-samples#43

Open

ninadhatkar mentioned this pull request Jun 30, 2022

[Snyk] Security upgrade twilio from 2.11.1 to 3.17.1 ninadhatkar/nodejs-docs-samples#265

Open

ahrarmonsur mentioned this pull request Nov 8, 2022

samples: migrate code from googleapis/nodejs-monitoring #2807

Merged

NimJay mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-language #2827

Merged

NimJay pushed a commit that referenced this pull request Nov 10, 2022

fix: correct AutoML Natural Language region tags to match with all ot…

8ae6987

…her languages. (#335)

NimJay pushed a commit that referenced this pull request Nov 10, 2022

fix: correct AutoML Natural Language region tags to match with all ot…

c90b746

…her languages. (#335)

ace-n mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-document-ai #2842

Closed

ace-n pushed a commit that referenced this pull request Nov 11, 2022

fix(deps): update dependency @google-cloud/storage to v6 (#335)

1a4b6ae

ace-n pushed a commit that referenced this pull request Nov 11, 2022

fix(deps): update dependency @google-cloud/storage to v6 (#335)

cc14ec8

ace-n mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-document-ai #2843

Merged

ace-n pushed a commit that referenced this pull request Nov 12, 2022

fix(deps): update dependency @google-cloud/storage to v6 (#335)

21aa267

ace-n mentioned this pull request Nov 14, 2022

migrate code from googleapis/nodejs-compute #2846

Closed

ace-n pushed a commit that referenced this pull request Nov 14, 2022

fix(deps): update dependency @google-cloud/storage to v6 (#335)

7dd7b50

ace-n mentioned this pull request Nov 15, 2022

migrate code from googleapis/nodejs-compute #2853

Merged

ace-n pushed a commit that referenced this pull request Nov 16, 2022

chore: release 2.6.3 (#335)

3ba734a

ace-n mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-video-intelligence #2855

Merged

telpirion mentioned this pull request Nov 16, 2022

chore(vision): migrate code from googleapis/nodejs-vision #2858

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: release 2.6.3 (#335)

c388abf

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

chore: release 2.6.3 (#335)

ffcaec1

NimJay pushed a commit that referenced this pull request Nov 19, 2022

feat: adding sample for instantiate inline workflow template (#335)

00df148

NimJay mentioned this pull request Nov 19, 2022

migrate code from googleapis/nodejs-dataproc #2878

Merged

NimJay pushed a commit that referenced this pull request Nov 19, 2022

feat: adding sample for instantiate inline workflow template (#335)

9c46a00

Shabirmean pushed a commit that referenced this pull request Feb 16, 2023

chore: release 1.5.0 (#335)

6c61cd0

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

Shabirmean mentioned this pull request Feb 16, 2023

samples: migrate code from googleapis/nodejs-dlp #3035

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Travis: fix failing tests + update dependencies #335

Travis: fix failing tests + update dependencies #335

ace-n commented Apr 4, 2017

ace-n commented Apr 5, 2017

ace-n commented Apr 5, 2017

theacodes Apr 5, 2017

Travis: fix failing tests + update dependencies #335

Travis: fix failing tests + update dependencies #335

Conversation

ace-n commented Apr 4, 2017

ace-n commented Apr 5, 2017

ace-n commented Apr 5, 2017

theacodes Apr 5, 2017

Choose a reason for hiding this comment