Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update o2a converter to support Airflow 2 #696

Closed
wants to merge 6 commits into from

Conversation

MaksYermak
Copy link
Collaborator

No description provided.

@MaksYermak MaksYermak self-assigned this Jun 1, 2023
@google-cla
Copy link

google-cla bot commented Jun 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

requirements.txt Outdated
@@ -1,23 +1,23 @@
apache-airflow==1.10.14 # pyup: ignore
apache-airflow==2.6.0 # pyup: ignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this requirement mean that this tool will be used only for Airflow 2.6.0?
If so, can we have e.g. some range here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this tool uses some utils functions and AirflowExeception from the airflow package. On conversion this package nohow influences and users could use this tool for all Airflow 2 sub-verision.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, sg

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the documentation as well to describe the supported versions?

@ayy1ma
Copy link

ayy1ma commented Jul 31, 2023

Can we approve and merge this to main, I recently tested few DAGs on Airflow 2.0, It seems to work as desired. Any ETA when the merge can happen? Does the tool come out of deprecation if Airflow 2.0 is supported?

@michalmodras
Copy link
Collaborator

@ayy1ma We're in the process of testing and fixing some edge cases. We plan to submit this in the upcoming weeks, and therefor release a new major version of the tool (supporting Airflow 2.x) that will be supported. The version of the tool supporting Airflow 1.x will continue to be deprecated.

Change-Id: I86fad2acf917530d278dd36317e8673f359d68a3
Change-Id: Ie75b1ff42b068b74e84c18e85ed0d653f6c78c4a
Change-Id: Ia879ed529ed6c909fde879ffcbb8c9a76c0a8cf9
Change-Id: I3b9ab1ba44c746abd90ed30dbf53b0cc1090da67
* Update folder structure for o2a_libs

* Update README.md and pyproject.toml files
@MaksYermak
Copy link
Collaborator Author

These changes were merged into the main branch.

@MaksYermak MaksYermak closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants