Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make span naming more consistent with other languages #109

Closed
dashpole opened this issue Oct 26, 2020 · 1 comment
Closed

Make span naming more consistent with other languages #109

dashpole opened this issue Oct 26, 2020 · 1 comment
Labels
trace

Comments

@dashpole
Copy link
Contributor

Default span naming in the go exporter is Span.<kind>.<name>. According to @aabmass, it is just <name> for python and for javascript. Since the opentelemetry collector is written in golang, this means a python application's span naming will change if it sends to a collector vs if it sends directly to stackdriver.
@punya punya added the trace label Feb 1, 2021
@aabmass aabmass mentioned this issue Mar 5, 2021
Closed
tbarker25 added a commit that referenced this issue Mar 16, 2021
@tbarker25
Display name format: just use span.Name
351c14d 
See:
#151

#109
@tbarker25 tbarker25 mentioned this issue Mar 16, 2021
Merged
tbarker25 added a commit that referenced this issue Mar 16, 2021
@tbarker25
Display name format: just use span.Name (#155)
402033a 
See:
#151

#109
@tbarker25
Copy link
Contributor

This should be fixed by #155

@punya punya mentioned this issue Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
trace
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@punya @dashpole @tbarker25