-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize metric integration tests #674
Conversation
Codecov Report
@@ Coverage Diff @@
## main #674 +/- ##
==========================================
+ Coverage 69.05% 69.54% +0.48%
==========================================
Files 36 36
Lines 4699 4699
==========================================
+ Hits 3245 3268 +23
+ Misses 1302 1278 -24
- Partials 152 153 +1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d12e4de
to
7511a92
Compare
8888287
to
6af55fc
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing blocking, but some suggestions.
it would also be nice if we added a comment on each test explaining what are the critical things to look for in the input/output fixtures. some are pretty self-explanatory but as they get more complex it gets harder to verify the expected fixtures
clarified all of the test case names to make expectations clearer. |
My motivation for this is to be able to link to individual fixtures for each metric type (gauge, sum, non-monotonic sum, etc) for the standard and GMP exporter in documentation.
This is probably easiest to review commit-by-commit.
.
s so that it tests sanitization.