fix(monitoring-exporter): convert to GCM format based on metric data type, not instrument type #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the exporter work with views (see included snapshot test), where the data point type will not match the instrument type. Otherwise the behavior of the exporter is unchanged.
Note the
InstrumentDescriptor.name
is still the only place to get the metric's name and it actually will match the name configured for output in the view. This is confusing, discussion going on in open-telemetry/opentelemetry-js#3439