Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Set a 30 second timeout on curling metrics URLs #1406

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

martijnvans
Copy link
Contributor

Description

This is to avoid a 2 hour hang when the curl operations hang because of shenanigans inside TestPortsAndAPIHealthChecks.

Related issue

none filed.

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans changed the title Set a 30 second timeout on curling metrics URLs Testing: Set a 30 second timeout on curling metrics URLs Sep 7, 2023
@martijnvans
Copy link
Contributor Author

test failures are unrelated; merging.

@martijnvans martijnvans merged commit 37e2384 into master Sep 11, 2023
49 of 55 checks passed
@martijnvans martijnvans deleted the martijnvans-timeout-diagnostics branch September 11, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants