Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added anthos api to config controller creation #704

Merged
merged 7 commits into from
Nov 23, 2023

Conversation

cartyc
Copy link
Contributor

@cartyc cartyc commented Nov 17, 2023

Updated LZ readme to include the anthos.googleapis.com to enable Config Sync as part of GKE-Enterprise's GA release.

If the API is not enabled then Config Sync data will not show in the Config UI as expected.

fmichaelobrien
fmichaelobrien previously approved these changes Nov 17, 2023
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fmichaelobrien
Copy link
Contributor

fmichaelobrien commented Nov 17, 2023

Thanks Chris, I'll check the scripts for the same enable for the gke enterprise release

20231121 see #710

Screenshot 2023-11-22 at 14 49 04

fmichaelobrien
fmichaelobrien previously approved these changes Nov 23, 2023
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks Chris
also tested this change in #711

Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@davelanglois-ssc davelanglois-ssc merged commit bc7c62e into GoogleCloudPlatform:main Nov 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants