Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update region tags for existing Imagen samples #11412

Merged
merged 2 commits into from
Apr 5, 2024
Merged

feat: update region tags for existing Imagen samples #11412

merged 2 commits into from
Apr 5, 2024

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented Apr 4, 2024

Description

Fixes b:329291575

  • Please merge this PR for me once it is approved

@irataxy irataxy requested review from a team as code owners April 4, 2024 22:05
Copy link

snippet-bot bot commented Apr 4, 2024

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 4, 2024
Copy link
Contributor

@m-strzelczyk m-strzelczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get rid of the snippet bot complaints, just make it double-region tagged. It's OK to have two region tags overlap. Then, when the docs are updated to use the new tag, you'll be able to remove the old tags from here.

@irataxy
Copy link
Contributor Author

irataxy commented Apr 5, 2024

To get rid of the snippet bot complaints, just make it double-region tagged. It's OK to have two region tags overlap. Then, when the docs are updated to use the new tag, you'll be able to remove the old tags from here.

Done

@irataxy irataxy merged commit 957aecc into GoogleCloudPlatform:main Apr 5, 2024
10 of 11 checks passed
@irataxy irataxy deleted the region-tag branch April 5, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants