Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve triggers #1561

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 30, 2019

No description provided.

Signed-off-by: David Gageot <david@gageot.net>
This fix was introduced by, but unrelated to, GoogleContainerTools#1439

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #1561 into master will decrease coverage by 0.04%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
- Coverage   46.03%   45.99%   -0.05%     
==========================================
  Files         118      118              
  Lines        4905     4918      +13     
==========================================
+ Hits         2258     2262       +4     
- Misses       2421     2429       +8     
- Partials      226      227       +1
Impacted Files Coverage Δ
pkg/skaffold/watch/triggers.go 32.6% <47.36%> (-0.73%) ⬇️
pkg/skaffold/watch/watch.go 82.6% <60%> (-3.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc2288...57641f1. Read the comment docs.

@balopat balopat merged commit fe6e441 into GoogleContainerTools:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants