Check cached artifacts in parallel #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1821 +/- ##
=========================================
- Coverage 45.55% 45.45% -0.1%
=========================================
Files 143 143
Lines 6687 6679 -8
=========================================
- Hits 3046 3036 -10
- Misses 3335 3337 +2
Partials 306 306
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
cache-parallel
branch
2 times, most recently
from
30a23ec
to
840d464
Compare
priyawadhwa
approved these changes
Mar 18, 2019
priyawadhwa
reviewed
Mar 18, 2019
|
|
||
| lock.Lock() | ||
| defer lock.Unlock() | ||
| case d := <-detailsErrs[i]: |
There was a problem hiding this comment.
Is there a chance we could ever get here before detailsErrs[i] has been saved?
There was a problem hiding this comment.
No, the array is initialised in the previous loop, in the main go routine.
Signed-off-by: David Gageot <david@gageot.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1819
Signed-off-by: David Gageot david@gageot.net