Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move gRPC and HTTP server logic out of event package #2199

Merged
merged 1 commit into from
May 29, 2019

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented May 29, 2019

This moves the server creation logic out of the event package. No functional change.

@codecov-io
Copy link

Codecov Report

Merging #2199 into master will increase coverage by 0.08%.
The diff coverage is 46.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
+ Coverage   57.88%   57.96%   +0.08%     
==========================================
  Files         187      188       +1     
  Lines        7903     7911       +8     
==========================================
+ Hits         4575     4586      +11     
- Misses       2915     2916       +1     
+ Partials      413      409       -4
Impacted Files Coverage Δ
pkg/skaffold/server/endpoints.go 0% <0%> (ø)
pkg/skaffold/event/event.go 89.65% <10%> (-1.96%) ⬇️
pkg/skaffold/server/server.go 51.66% <64.7%> (ø)
pkg/skaffold/runner/runner.go 69.1% <66.66%> (+0.25%) ⬆️
pkg/skaffold/util/port.go 92.59% <0%> (+7.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45dcebd...821de0d. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkubala nkubala merged commit da660f2 into GoogleContainerTools:master May 29, 2019
@nkubala nkubala deleted the server-init branch May 29, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants