-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update skaffold init --analyze to handle more builder types #2327
Update skaffold init --analyze to handle more builder types #2327
Conversation
…d into update-skaffold-init-analyze
Codecov Report
|
…d into update-skaffold-init-analyze
@nkubala any chance you could look at this, given you familiarity with skaffold init? |
Looks good. I believe the VS code team is in sync with the schema change? |
@chanseokoh Yeah, although there's one request to change Docker's payload to be in the form of |
@sujit-kamireddy Feel free to take a look and suggest changes as well. |
Merging this will break the IDEs due to the new output format. Thanks @balopat for bringing this up. Please hold on merging this till we lock on the plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed on to put this behind a hidden feature flag to keep backward compatibility for now with the Cloud Code extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balopat done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit on the nit fixes then it's LGTM!
This is a follow-up to #2274.
Currently,
skaffold init --analyze
only shows dockerfiles and k8s images found, which isn't useful for non-dockerfile-based builder detection. This PR updates the schema to provide more useful information for IDEs to consume.This PR:
false
) and which pairs will require prompting from the user (true
) (with the addition of the Jib builder, some builder/image pairs will be automatically resolved).Previous output:
Example new output: