Turn RPC State forwardedPorts into map keyed by the local port #2659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2657 by turning
forwardedPorts
into a map keyed by the local port. With this change, I see the full list of forwarded ports as I was expecting. Using the local port also ensures that reallocated ports are overwritten.This PR uses a new field number, so it should be backwards compatible (though I'm not sure how about the JSON interface).
Neither Cloud Code for VSCode nor IntelliJ use the state object and so are unaffected.
(Note: you may notice that the
npm
container has no ports listed; they're somehow terminated. Will file that separately.)