-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ephemeralstorage and ResourceStorage for kaniko pods #3013
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @prary! Please add the tests for the new code. Also, would it make sense to also be able to configure ResourceStorage
? (Maybe in another PR)
hi @dgageot I will add test case and yes it totally make sense configuring ResourceStorage as well. |
@prary yes. Thanks a lot! |
@dgageot added ResourceStorage as well :) |
Not sure why build is failing it is passing locally and I did ran make generate - schema |
@prary This happens on one of my PRs too. Not sure what's happening... |
My guess is that this happens when there is a schema change in master. Can you try to rebase and try locally? |
@prary It looks like you changed latest schema that's v17 now, not v16. I had the same issue and |
#2990 Adding ephemeral storage for kaniko pod
Before
After
Next PRs.
N/A