Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ephemeralstorage and ResourceStorage for kaniko pods #3013

Merged
merged 7 commits into from
Oct 21, 2019

Conversation

prary
Copy link
Contributor

@prary prary commented Oct 8, 2019

#2990 Adding ephemeral storage for kaniko pod

Before

requests: 
  cpu:             2
  memory:             1Gi
limits: 
  cpu:             2
  memory:             1Gi

After

requests: 
  cpu:             2
  memory:             1Gi
  ephemeralStorage : 1Gi
limits: 
  cpu:             2
  memory:             1Gi
  ephemeralStorage : 1Gi

Next PRs.
N/A

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #3013 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta16/upgrade.go 77.77% <ø> (ø) ⬆️
pkg/skaffold/build/cluster/sources/sources.go 91.58% <100%> (+0.67%) ⬆️

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Oct 8, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 8, 2019
Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @prary! Please add the tests for the new code. Also, would it make sense to also be able to configure ResourceStorage? (Maybe in another PR)

@prary
Copy link
Contributor Author

prary commented Oct 15, 2019

hi @dgageot I will add test case and yes it totally make sense configuring ResourceStorage as well.
Just to confirm test case testing resourceRequirements function right?

@dgageot
Copy link
Contributor

dgageot commented Oct 15, 2019

@prary yes. Thanks a lot!

@prary prary changed the title Adding ephemeralstorage for kaniko pods Adding ephemeralstorage and ResourceStorage for kaniko pods Oct 17, 2019
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 17, 2019
@prary
Copy link
Contributor Author

prary commented Oct 17, 2019

@dgageot added ResourceStorage as well :)

@prary
Copy link
Contributor Author

prary commented Oct 17, 2019

Not sure why build is failing it is passing locally and I did ran make generate - schema

@dgageot
Copy link
Contributor

dgageot commented Oct 17, 2019

@prary This happens on one of my PRs too. Not sure what's happening...

@balopat
Copy link
Contributor

balopat commented Oct 17, 2019

My guess is that this happens when there is a schema change in master. Can you try to rebase and try locally?

@dgageot
Copy link
Contributor

dgageot commented Oct 17, 2019

@prary It looks like you changed latest schema that's v17 now, not v16. I had the same issue and make generate-schemas didn't fix the issue. I need to investigate

@tejal29 tejal29 merged commit dce1a1c into GoogleContainerTools:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants