Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align kubectl/kustomize cleanup output with deploy output #3103

Merged
merged 1 commit into from Oct 21, 2019
Merged

Align kubectl/kustomize cleanup output with deploy output #3103

merged 1 commit into from Oct 21, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 21, 2019

Signed-off-by: David Gageot david@gageot.net

Before:
before

After:
after

@dgageot
Align kubectl/kustomize cleanup output with deploy output
88e265a 
Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Oct 21, 2019 •
edited

Codecov Report

Merging #3103 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kustomize.go 74.4% <100%> (ø) ⬆️
pkg/skaffold/deploy/kubectl.go 64.17% <100%> (ø) ⬆️

@nkubala nkubala merged commit 871fe62 into GoogleContainerTools:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgageot @nkubala @googlebot