Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new t.Cleanup() to simplify tests #3815

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Use new t.Cleanup() to simplify tests #3815

merged 1 commit into from
Mar 16, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 11, 2020

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented Mar 11, 2020 •
edited
Loading

Codecov Report

Merging #3815 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@loosebazooka loosebazooka mentioned this pull request Mar 11, 2020
Merged
@loosebazooka
Copy link
Member

I think we need to update https://github.com/GoogleContainerTools/skaffold/blob/master/integration/sync_test.go#L86 ?

nkubala
nkubala approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, much cleaner

nkubala
nkubala suggested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, just saw @loosebazooka's comment. can you update the auto sync test?

@dgageot
Use new t.Cleanup() to simplify tests
37d3963 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Copy link
Contributor Author

dgageot commented Mar 16, 2020

@nkubala done

nkubala
nkubala approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge when green

@nkubala nkubala merged commit c586a07 into GoogleContainerTools:master Mar 16, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@briandealwis briandealwis Awaiting requested review from briandealwis

@chanseokoh chanseokoh Awaiting requested review from chanseokoh

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

@TadCordle TadCordle Awaiting requested review from TadCordle

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgageot @loosebazooka @nkubala @googlebot