Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail fast if the Dockerfile can’t be found #3999

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fail fast if the Dockerfile can’t be found #3999

merged 1 commit into from
Apr 21, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 21, 2020

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented Apr 21, 2020 •
edited
Loading

Codecov Report

Merging #3999 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted Files Coverage Δ
pkg/skaffold/build/local/docker.go 80.76% <33.33%> (-7.24%) ⬇️
pkg/skaffold/docker/dependencies.go 72.60% <100.00%> (+0.77%) ⬆️
pkg/skaffold/util/tar.go 57.47% <0.00%> (+4.59%) ⬆️

briandealwis
briandealwis approved these changes Apr 21, 2020
View reviewed changes
pkg/skaffold/docker/dependencies.go Outdated Show resolved Hide resolved
@dgageot
Fail fast if the Dockerfile can’t be found
933ceab 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 17e1e02 into GoogleContainerTools:master Apr 21, 2020
@dgageot dgageot mentioned this pull request Apr 28, 2020
Closed
@fmotrifork fmotrifork mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @briandealwis @googlebot