Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always print ctrl-c message #4214

Merged
merged 1 commit into from
May 19, 2020
Merged

Always print ctrl-c message #4214

merged 1 commit into from
May 19, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 18, 2020

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented May 18, 2020 •
edited
Loading

Codecov Report

Merging #4214 into master will increase coverage by 0.03%.
The diff coverage is 25.00%.

Impacted Files Coverage Δ
pkg/skaffold/runner/build_deploy.go 68.81% <0.00%> (+1.44%) ⬆️
pkg/skaffold/runner/dev.go 66.66% <100.00%> (+0.25%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0.00%> (+2.43%) ⬆️

@dgageot
Always print ctrl-c message
f1d2977 
Signed-off-by: David Gageot <david@gageot.net>
@tejal29 tejal29 merged commit e9f74c6 into GoogleContainerTools:master May 19, 2020
@fmotrifork fmotrifork mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@briandealwis briandealwis Awaiting requested review from briandealwis

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @tejal29 @googlebot