Remove labels from builders and deployers #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4499 +/- ##
==========================================
+ Coverage 72.35% 72.48% +0.13%
==========================================
Files 333 334 +1
Lines 12956 12934 -22
==========================================
+ Hits 9374 9375 +1
+ Misses 2984 2962 -22
+ Partials 598 597 -1
Continue to review full report at Codecov.
|
nkubala
force-pushed
the
remove-labels
branch
2 times, most recently
from
1f7e778
to
3360a24
Compare
dgageot
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3133
third attempt after #4485 (second attempt after #4466) - travis was giving strange and unresolvable errors.
this removes all labels set by skaffold except for skaffold.dev/run-id, and app.kubernetes.io/managed-by=skaffold. this does remove the version from the managed-by label though, so changing skaffold version will not cause issues.
because we don't apply labels from build or deploy, we can remove this from their interfaces, as well as remove passing an array of Labellers to Deploy and Render. the labels are computed once when the runner is created, and stored inside the deployer.