Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a user agent to GCB calls. #582

Merged
merged 1 commit into from May 23, 2018

Conversation

Projects
None yet
2 participants
@dlorenc
Copy link
Member

commented May 23, 2018

No description provided.

@dlorenc dlorenc requested review from dgageot, r2d4 and viglesiasce as code owners May 23, 2018

@dlorenc

This comment has been minimized.

Copy link
Member Author

commented May 23, 2018

Fixes #573

@r2d4

r2d4 approved these changes May 23, 2018

Copy link
Contributor

left a comment

I think we should add platform to the useragent too. Feel free to merge after that

@dlorenc dlorenc force-pushed the dlorenc:user branch from ff6acbd to 996dd87 May 23, 2018

@dlorenc

This comment has been minimized.

Copy link
Member Author

commented May 23, 2018

I think we should add platform to the useragent too. Feel free to merge after that

Good call.

@dlorenc dlorenc merged commit c98eed2 into GoogleContainerTools:master May 23, 2018

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro CI build successful.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.