Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a user agent to GCB calls. #582

Merged
merged 1 commit into from
May 23, 2018
Merged

Add a user agent to GCB calls. #582

merged 1 commit into from
May 23, 2018

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented May 23, 2018

No description provided.

@dlorenc
Copy link
Contributor Author

dlorenc commented May 23, 2018

Fixes #573

r2d4
r2d4 approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add platform to the useragent too. Feel free to merge after that

@dlorenc
Copy link
Contributor Author

dlorenc commented May 23, 2018

I think we should add platform to the useragent too. Feel free to merge after that

Good call.

@dlorenc dlorenc merged commit c98eed2 into GoogleContainerTools:master May 23, 2018
This was referenced Oct 28, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r2d4 r2d4 r2d4 approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlorenc @r2d4