-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Add proto for render error code and suggestions. #5953
[v3] Add proto for render error code and suggestions. #5953
Conversation
d1ff56b
to
480bceb
Compare
480bceb
to
ccca995
Compare
Codecov Report
@@ Coverage Diff @@
## master #5953 +/- ##
==========================================
+ Coverage 70.69% 70.71% +0.01%
==========================================
Files 459 462 +3
Lines 17585 17832 +247
==========================================
+ Hits 12432 12610 +178
- Misses 4234 4291 +57
- Partials 919 931 +12
Continue to review full report at Codecov.
|
ccca995
to
815f4e1
Compare
815f4e1
to
eec0c5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix nit and then submit!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change all references to Whitelist to allowlist
eec0c5c
to
0739ada
Compare
0739ada
to
4c20c99
Compare
Fixes: #nnn
Related: #5673
Merge after: #5942
TO reviewers:
This is diff-based from #5942. Please only review the last commit