Asciidocs and refdocs tooling #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
requested review from
dgageot,
dlorenc,
r2d4 and
viglesiasce
as code owners
r2d4
approved these changes
Jun 8, 2018
docs/index.adoc
Outdated
| :doctype: book | ||
| :github-repo-tree: http://github.com/GoogleContainerTools/skaffold/tree/{commit} | ||
|
|
||
| ===== |
There was a problem hiding this comment.
Hide these from the github preview if you can
|
Sorry @balopat, you have to rebase |
r2d4
reviewed
Jun 8, 2018
| steps: | ||
| # Build the container that will do the go build. | ||
| - name: 'gcr.io/cloud-builders/docker' | ||
| args: ['build', '-t', 'gcr.io/k8s-skaffold/skaffold:$TAG_NAME', '-f', 'deploy/skaffold/Dockerfile', '.'] | ||
| # Do the go build. | ||
| - name: 'gcr.io/k8s-skaffold/skaffold:$TAG_NAME' | ||
| args: ['make', 'cross'] | ||
| args: ['make', 'cross', 'docs'] |
There was a problem hiding this comment.
this fails @balopat
docker is not in the integration test image. I would move this to a separate step (I don't want to add asciidoctor to the integration/published skaffold image
There was a problem hiding this comment.
sounds good. I'll fix it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in context of #629.
See generated example:
Documentation tooling requirements:
Additional goals:
Layout goals: