Fix issue #404 - Allow to use bazel subtarget #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fclaeys
requested review from
dgageot,
dlorenc,
r2d4 and
viglesiasce
as code owners
fclaeys
force-pushed
the
fix404
branch
2 times, most recently
from
43e9827
to
3f4e502
Compare
dlorenc
reviewed
Jun 18, 2018
pkg/skaffold/build/bazel.go
Outdated
| func trimTarget(buildTarget string) string { | ||
|
|
||
| //TODO(r2d4): strip off leading //:, bad | ||
| trimedTarget := strings.TrimPrefix(buildTarget, "//") |
There was a problem hiding this comment.
nit: typos. Could you rename these to "trimmed"?
fclaeys
force-pushed
the
fix404
branch
2 times, most recently
from
3889ad4
to
31cf7ec
Compare
|
@fclaeys Can you please rebase to both update the branch and run the windows tests? Thanks! |
|
@dgageot branch updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dgageot @r2d4 Here is a first implementation to fix #404
This is my first contribution on the project do not hesitate to make me your remarks to improve the code.