Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use go 1.17.x in verify-examples github action #7088

Merged

Conversation

MarlonGamez
Copy link
Contributor

Description
This PR uses the setup-go action to make sure we are using go v1.17.x in our job that verifies changes to skaffold's examples.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #7088 (2bfd1e8) into main (290280e) will decrease coverage by 1.82%.
The diff coverage is 56.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7088      +/-   ##
==========================================
- Coverage   70.48%   68.66%   -1.83%     
==========================================
  Files         515      558      +43     
  Lines       23150    26080    +2930     
==========================================
+ Hits        16317    17907    +1590     
- Misses       5776     6942    +1166     
- Partials     1057     1231     +174     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 209 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b931d...2bfd1e8. Read the comment docs.

@briandealwis briandealwis enabled auto-merge (squash) February 9, 2022 13:46
@tejal29 tejal29 disabled auto-merge February 9, 2022 21:19
@tejal29 tejal29 added the kokoro:force-run forces a kokoro re-run on a PR label Feb 9, 2022
@tejal29
Copy link
Member

tejal29 commented Feb 9, 2022

kokoro job failed due to timeout. Retriggering.

@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Feb 9, 2022
@tejal29 tejal29 enabled auto-merge (squash) February 9, 2022 21:33
@MarlonGamez
Copy link
Contributor Author

@tejal29 I think this has been happening consistently on all PRs I've seen. I'll open an issue for this

@MarlonGamez
Copy link
Contributor Author

MarlonGamez commented Feb 9, 2022

Merging this as kokoro failure is unrelated

@MarlonGamez MarlonGamez merged commit 913e53f into GoogleContainerTools:main Feb 9, 2022
@MarlonGamez MarlonGamez deleted the github-action-fix branch February 9, 2022 23:07
MarlonGamez added a commit to MarlonGamez/skaffold that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants