Support wildcards in Dockerfiles #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
force-pushed
the
fix-709
branch
2 times, most recently
from
48fbd67
to
ec5fcc2
Compare
dgageot
force-pushed
the
fix-709
branch
3 times, most recently
from
0e034f6
to
b53fa04
Compare
balopat
approved these changes
Jun 21, 2018
pkg/skaffold/docker/parse.go
Outdated
|
|
||
| files, err := filepath.Glob(path) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "glob") |
There was a problem hiding this comment.
nit: a bit more descriptive error message?
There was a problem hiding this comment.
oh yes, let me fix that
Fixes 709 Signed-off-by: David Gageot <david@gageot.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 709
Signed-off-by: David Gageot david@gageot.net