Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t always fail if some COPY patterns don't match any file #744

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 25, 2018

Docker does not seem to mind if a wildcard matches no files so long as there is at least one file found on the statement to copy.

Fixes #741

Signed-off-by: David Gageot david@gageot.net

Docker does not seem to mind if a wildcard matches no files so long as there is at least one file found on the statement to copy.

Fixes GoogleContainerTools#741

Signed-off-by: David Gageot <david@gageot.net>
@balopat balopat self-assigned this Jun 25, 2018
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dgageot dgageot merged commit 2d1d68d into GoogleContainerTools:master Jun 25, 2018
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we warn the user that wildcard pattern *.whatever didn't match any files, so it's a noop? A silent failure could be potentially frustrating

@dgageot dgageot deleted the fix-741 branch December 28, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants