Code Quality: Fix flakey canvas keys karma test #13224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushnirwal
added
Type: Code Quality
|
Plugin builds for 42db569 are ready 🛎️!
|
|
Size Change: -7 B (0%) Total Size: 2.73 MB ℹ️ View Unchanged
|
swissspidy
reviewed
Apr 25, 2023
packages/story-editor/src/components/canvas/karma/canvasKeys.karma.js
Outdated
Show resolved
Hide resolved
swissspidy
approved these changes
Apr 25, 2023
swissspidy
changed the title
canvasKeys.karma.js integration test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Integration test with name
should play pause animation when pressing mod+enter shortcuthas been failing on many PRs which don't affect the responsible code. Manually doing the steps described in the test shows no error.Summary
It seems that the failure comes from
Dropdownbeing unresponsive for a few milliseconds after changing its state. Thus the click here does not close the Dropdown and the click after that selects the "None" option. This makes the assertion checking for "Play Page Animations" label fail.Adding a delay before closing the effect chooser drop-down seems to help.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #